Bug Summary

File:src/usr.bin/openssl/dsaparam.c
Warning:line 336, column 4
Value stored to 'i' is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name dsaparam.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.bin/openssl/obj -resource-dir /usr/local/lib/clang/13.0.0 -D LIBRESSL_INTERNAL -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.bin/openssl/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/usr.bin/openssl/dsaparam.c
1/* $OpenBSD: dsaparam.c,v 1.12 2021/11/20 18:10:48 tb Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved.
4 *
5 * This package is an SSL implementation written
6 * by Eric Young (eay@cryptsoft.com).
7 * The implementation was written so as to conform with Netscapes SSL.
8 *
9 * This library is free for commercial and non-commercial use as long as
10 * the following conditions are aheared to. The following conditions
11 * apply to all code found in this distribution, be it the RC4, RSA,
12 * lhash, DES, etc., code; not just the SSL code. The SSL documentation
13 * included with this distribution is covered by the same copyright terms
14 * except that the holder is Tim Hudson (tjh@cryptsoft.com).
15 *
16 * Copyright remains Eric Young's, and as such any Copyright notices in
17 * the code are not to be removed.
18 * If this package is used in a product, Eric Young should be given attribution
19 * as the author of the parts of the library used.
20 * This can be in the form of a textual message at program startup or
21 * in documentation (online or textual) provided with the package.
22 *
23 * Redistribution and use in source and binary forms, with or without
24 * modification, are permitted provided that the following conditions
25 * are met:
26 * 1. Redistributions of source code must retain the copyright
27 * notice, this list of conditions and the following disclaimer.
28 * 2. Redistributions in binary form must reproduce the above copyright
29 * notice, this list of conditions and the following disclaimer in the
30 * documentation and/or other materials provided with the distribution.
31 * 3. All advertising materials mentioning features or use of this software
32 * must display the following acknowledgement:
33 * "This product includes cryptographic software written by
34 * Eric Young (eay@cryptsoft.com)"
35 * The word 'cryptographic' can be left out if the rouines from the library
36 * being used are not cryptographic related :-).
37 * 4. If you include any Windows specific code (or a derivative thereof) from
38 * the apps directory (application code) you must include an acknowledgement:
39 * "This product includes software written by Tim Hudson (tjh@cryptsoft.com)"
40 *
41 * THIS SOFTWARE IS PROVIDED BY ERIC YOUNG ``AS IS'' AND
42 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
43 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
44 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
45 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
46 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
47 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
48 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
49 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
50 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
51 * SUCH DAMAGE.
52 *
53 * The licence and distribution terms for any publically available version or
54 * derivative of this code cannot be changed. i.e. this code cannot simply be
55 * copied and put under another distribution licence
56 * [including the GNU Public Licence.]
57 */
58
59#include <openssl/opensslconf.h> /* for OPENSSL_NO_DSA */
60
61/* Until the key-gen callbacks are modified to use newer prototypes, we allow
62 * deprecated functions for openssl-internal code */
63#ifdef OPENSSL_NO_DEPRECATED
64#undef OPENSSL_NO_DEPRECATED
65#endif
66
67#include <limits.h>
68#include <stdio.h>
69#include <stdlib.h>
70#include <string.h>
71#include <time.h>
72
73#include "apps.h"
74
75#include <openssl/bio.h>
76#include <openssl/bn.h>
77#include <openssl/err.h>
78#include <openssl/dsa.h>
79#include <openssl/pem.h>
80#include <openssl/x509.h>
81
82static struct {
83 int C;
84 int genkey;
85 char *infile;
86 int informat;
87 int noout;
88 char *outfile;
89 int outformat;
90 int text;
91} dsaparam_config;
92
93static const struct option dsaparam_options[] = {
94 {
95 .name = "C",
96 .desc = "Convert DSA parameters into C code",
97 .type = OPTION_FLAG,
98 .opt.flag = &dsaparam_config.C,
99 },
100 {
101 .name = "genkey",
102 .desc = "Generate a DSA key",
103 .type = OPTION_FLAG,
104 .opt.flag = &dsaparam_config.genkey,
105 },
106 {
107 .name = "in",
108 .argname = "file",
109 .desc = "Input file (default stdin)",
110 .type = OPTION_ARG,
111 .opt.arg = &dsaparam_config.infile,
112 },
113 {
114 .name = "inform",
115 .argname = "format",
116 .desc = "Input format (DER or PEM (default))",
117 .type = OPTION_ARG_FORMAT,
118 .opt.value = &dsaparam_config.informat,
119 },
120 {
121 .name = "noout",
122 .desc = "No output",
123 .type = OPTION_FLAG,
124 .opt.flag = &dsaparam_config.noout,
125 },
126 {
127 .name = "out",
128 .argname = "file",
129 .desc = "Output file (default stdout)",
130 .type = OPTION_ARG,
131 .opt.arg = &dsaparam_config.outfile,
132 },
133 {
134 .name = "outform",
135 .argname = "format",
136 .desc = "Output format (DER or PEM (default))",
137 .type = OPTION_ARG_FORMAT,
138 .opt.value = &dsaparam_config.outformat,
139 },
140 {
141 .name = "text",
142 .desc = "Print as text",
143 .type = OPTION_FLAG,
144 .opt.flag = &dsaparam_config.text,
145 },
146 { NULL((void*)0) },
147};
148
149static void
150dsaparam_usage(void)
151{
152 fprintf(stderr(&__sF[2]),
153 "usage: dsaparam [-C] [-genkey] [-in file]\n"
154 " [-inform format] [-noout] [-out file] [-outform format]\n"
155 " [-text] [numbits]\n\n");
156 options_usage(dsaparam_options);
157}
158
159static int dsa_cb(int p, int n, BN_GENCB *cb);
160
161int
162dsaparam_main(int argc, char **argv)
163{
164 DSA *dsa = NULL((void*)0);
165 int i;
166 BIO *in = NULL((void*)0), *out = NULL((void*)0);
167 BN_GENCB *cb = NULL((void*)0);
168 int ret = 1;
169 int numbits = -1;
170 char *strbits = NULL((void*)0);
171
172 if (single_execution) {
173 if (pledge("stdio cpath wpath rpath", NULL((void*)0)) == -1) {
174 perror("pledge");
175 exit(1);
176 }
177 }
178
179 memset(&dsaparam_config, 0, sizeof(dsaparam_config));
180
181 dsaparam_config.informat = FORMAT_PEM3;
182 dsaparam_config.outformat = FORMAT_PEM3;
183
184 if (options_parse(argc, argv, dsaparam_options, &strbits, NULL((void*)0)) != 0) {
185 dsaparam_usage();
186 goto end;
187 }
188
189 if (strbits != NULL((void*)0)) {
190 const char *errstr;
191 numbits = strtonum(strbits, 0, INT_MAX2147483647, &errstr);
192 if (errstr) {
193 fprintf(stderr(&__sF[2]), "Invalid number of bits: %s", errstr);
194 goto end;
195 }
196 }
197
198 in = BIO_new(BIO_s_file());
199 out = BIO_new(BIO_s_file());
200 if (in == NULL((void*)0) || out == NULL((void*)0)) {
201 ERR_print_errors(bio_err);
202 goto end;
203 }
204 if (dsaparam_config.infile == NULL((void*)0))
205 BIO_set_fp(in, stdin, BIO_NOCLOSE)BIO_ctrl(in,106,0x00,(char *)(&__sF[0]));
206 else {
207 if (BIO_read_filename(in, dsaparam_config.infile)BIO_ctrl(in,108, 0x01|0x02,(char *)dsaparam_config.infile) <= 0) {
208 perror(dsaparam_config.infile);
209 goto end;
210 }
211 }
212 if (dsaparam_config.outfile == NULL((void*)0)) {
213 BIO_set_fp(out, stdout, BIO_NOCLOSE)BIO_ctrl(out,106,0x00,(char *)(&__sF[1]));
214 } else {
215 if (BIO_write_filename(out, dsaparam_config.outfile)BIO_ctrl(out,108, 0x01|0x04,dsaparam_config.outfile) <= 0) {
216 perror(dsaparam_config.outfile);
217 goto end;
218 }
219 }
220
221 if (numbits > 0) {
222 if ((cb = BN_GENCB_new()) == NULL((void*)0)) {
223 BIO_printf(bio_err,
224 "Error allocating BN_GENCB object\n");
225 goto end;
226 }
227
228 BN_GENCB_set(cb, dsa_cb, bio_err){ BN_GENCB *tmp_gencb = (cb); tmp_gencb->ver = 2; tmp_gencb
->arg = (bio_err); tmp_gencb->cb.cb_2 = (dsa_cb); }
;
229
230 dsa = DSA_new();
231 if (!dsa) {
232 BIO_printf(bio_err, "Error allocating DSA object\n");
233 goto end;
234 }
235 BIO_printf(bio_err, "Generating DSA parameters, %d bit long prime\n", numbits);
236 BIO_printf(bio_err, "This could take some time\n");
237 if (!DSA_generate_parameters_ex(dsa, numbits, NULL((void*)0), 0, NULL((void*)0), NULL((void*)0), cb)) {
238 ERR_print_errors(bio_err);
239 BIO_printf(bio_err, "Error, DSA key generation failed\n");
240 goto end;
241 }
242 } else if (dsaparam_config.informat == FORMAT_ASN11)
243 dsa = d2i_DSAparams_bio(in, NULL((void*)0));
244 else if (dsaparam_config.informat == FORMAT_PEM3)
245 dsa = PEM_read_bio_DSAparams(in, NULL((void*)0), NULL((void*)0), NULL((void*)0));
246 else {
247 BIO_printf(bio_err, "bad input format specified\n");
248 goto end;
249 }
250 if (dsa == NULL((void*)0)) {
251 BIO_printf(bio_err, "unable to load DSA parameters\n");
252 ERR_print_errors(bio_err);
253 goto end;
254 }
255 if (dsaparam_config.text) {
256 DSAparams_print(out, dsa);
257 }
258 if (dsaparam_config.C) {
259 unsigned char *data;
260 int l, len, bits_p;
261
262 len = BN_num_bytes(dsa->p)((BN_num_bits(dsa->p)+7)/8);
263 bits_p = BN_num_bits(dsa->p);
264 data = malloc(len + 20);
265 if (data == NULL((void*)0)) {
266 perror("malloc");
267 goto end;
268 }
269 l = BN_bn2bin(dsa->p, data);
270 printf("static unsigned char dsa%d_p[] = {", bits_p);
271 for (i = 0; i < l; i++) {
272 if ((i % 12) == 0)
273 printf("\n\t");
274 printf("0x%02X, ", data[i]);
275 }
276 printf("\n\t};\n");
277
278 l = BN_bn2bin(dsa->q, data);
279 printf("static unsigned char dsa%d_q[] = {", bits_p);
280 for (i = 0; i < l; i++) {
281 if ((i % 12) == 0)
282 printf("\n\t");
283 printf("0x%02X, ", data[i]);
284 }
285 printf("\n\t};\n");
286
287 l = BN_bn2bin(dsa->g, data);
288 printf("static unsigned char dsa%d_g[] = {", bits_p);
289 for (i = 0; i < l; i++) {
290 if ((i % 12) == 0)
291 printf("\n\t");
292 printf("0x%02X, ", data[i]);
293 }
294 free(data);
295 printf("\n\t};\n\n");
296
297 printf("DSA *get_dsa%d()\n\t{\n", bits_p);
298 printf("\tDSA *dsa;\n\n");
299 printf("\tif ((dsa = DSA_new()) == NULL) return(NULL);\n");
300 printf("\tdsa->p = BN_bin2bn(dsa%d_p, sizeof(dsa%d_p), NULL);\n",
301 bits_p, bits_p);
302 printf("\tdsa->q = BN_bin2bn(dsa%d_q, sizeof(dsa%d_q), NULL);\n",
303 bits_p, bits_p);
304 printf("\tdsa->g = BN_bin2bn(dsa%d_g, sizeof(dsa%d_g), NULL);\n",
305 bits_p, bits_p);
306 printf("\tif ((dsa->p == NULL) || (dsa->q == NULL) || (dsa->g == NULL))\n");
307 printf("\t\t{ DSA_free(dsa); return(NULL); }\n");
308 printf("\treturn(dsa);\n\t}\n");
309 }
310 if (!dsaparam_config.noout) {
311 if (dsaparam_config.outformat == FORMAT_ASN11)
312 i = i2d_DSAparams_bio(out, dsa);
313 else if (dsaparam_config.outformat == FORMAT_PEM3)
314 i = PEM_write_bio_DSAparams(out, dsa);
315 else {
316 BIO_printf(bio_err, "bad output format specified for outfile\n");
317 goto end;
318 }
319 if (!i) {
320 BIO_printf(bio_err, "unable to write DSA parameters\n");
321 ERR_print_errors(bio_err);
322 goto end;
323 }
324 }
325 if (dsaparam_config.genkey) {
326 DSA *dsakey;
327
328 if ((dsakey = DSAparams_dup(dsa)) == NULL((void*)0))
329 goto end;
330 if (!DSA_generate_key(dsakey)) {
331 ERR_print_errors(bio_err);
332 DSA_free(dsakey);
333 goto end;
334 }
335 if (dsaparam_config.outformat == FORMAT_ASN11)
336 i = i2d_DSAPrivateKey_bio(out, dsakey);
Value stored to 'i' is never read
337 else if (dsaparam_config.outformat == FORMAT_PEM3)
338 i = PEM_write_bio_DSAPrivateKey(out, dsakey, NULL((void*)0), NULL((void*)0), 0, NULL((void*)0), NULL((void*)0));
339 else {
340 BIO_printf(bio_err, "bad output format specified for outfile\n");
341 DSA_free(dsakey);
342 goto end;
343 }
344 DSA_free(dsakey);
345 }
346 ret = 0;
347
348 end:
349 BIO_free(in);
350 BIO_free_all(out);
351 BN_GENCB_free(cb);
352 DSA_free(dsa);
353
354 return (ret);
355}
356
357static int
358dsa_cb(int p, int n, BN_GENCB *cb)
359{
360 char c = '*';
361
362 if (p == 0)
363 c = '.';
364 if (p == 1)
365 c = '+';
366 if (p == 2)
367 c = '*';
368 if (p == 3)
369 c = '\n';
370 BIO_write(BN_GENCB_get_arg(cb), &c, 1);
371 (void) BIO_flush(BN_GENCB_get_arg(cb))(int)BIO_ctrl(BN_GENCB_get_arg(cb),11,0,((void*)0));
372#ifdef GENCB_TEST
373 if (stop_keygen_flag)
374 return 0;
375#endif
376 return 1;
377}