/usr/src/games/robots/move.c

Bug Summary

File:	src/games/robots/move.c
Warning:	line 213, column 4 The left operand of '+' is a garbage value

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name move.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/games/robots/obj -resource-dir /usr/local/lib/clang/13.0.0 -D MAX_PER_UID=5 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/games/robots/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/games/robots/move.c

1/*	$OpenBSD: move.c,v 1.13 2016/08/27 02:02:44 guenther Exp $	*/
2/*	$NetBSD: move.c,v 1.4 1995/04/22 10:08:58 cgd Exp $	*/

4/*
* Copyright (c) 1980, 1993
*	The Regents of the University of California.  All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
*    notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
*    notice, this list of conditions and the following disclaimer in the
*    documentation and/or other materials provided with the distribution.
* 3. Neither the name of the University nor the names of its contributors
*    may be used to endorse or promote products derived from this software
*    without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/

33#include <sys/time.h>
34#include <ctype.h>
35#include <poll.h>
36#include <termios.h>
37#include <unistd.h>

39#include "robots.h"

41#define	ESC'\033'	'\033'

43/*
* get_move:
*	Get and execute a move from the player
*/
47void
48get_move(void)
49{
int	c;
int retval;
struct timespec t, tn;
53#ifdef FANCY
int lastmove;
55#endif

if (Waiting)
1
Assuming 'Waiting' is false→
2
←
Taking false branch→
return;

60#ifdef	FANCY
if (Pattern_roll) {
if (Next_move >= Move_list)
	lastmove = *Next_move;
else
	lastmove = -1;	/* flag for "first time in" */
}
67#endif
if (Real_time) {
3
←
Assuming 'Real_time' is false→
4
←
Taking false branch→
t = tv;
clock_gettime(CLOCK_MONOTONIC3, &tn);
}
for (;;) {
5
←
Loop condition is true.  Entering loop body→
if (Teleport && must_telep())
6
←
Assuming 'Teleport' is false→
	goto teleport;
if (Running)
7
←
Assuming 'Running' is true→
8
←
Taking true branch→
	c = Run_ch;
else if (Count != 0)
	c = Cnt_move;
79#ifdef	FANCY
else if (Num_robots > 1 && Stand_still)
	c = '>';
else if (Num_robots > 1 && Pattern_roll) {
	if (*++Next_move == '\0') {
		if (lastmove < 0)
			goto over;
		Next_move = Move_list;
	}
	c = *Next_move;
	mvaddch(0, 0, c)(wmove(stdscr,0,0) == (-1) ? (-1) : waddch(stdscr,c));
	if (c == lastmove)
		goto over;
}
93#endif
else {
95over:
	if (Real_time) {
		struct pollfd pfd[1];

		pfd[0].fd = STDIN_FILENO0;
		pfd[0].events = POLLIN0x0001;
		retval = ppoll(pfd, 1, &t, NULL((void *)0));
		if (retval > 0)
			c = getchar()(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])));
		else	/* Don't move if timed out or error */
			c = ' ';
	} else {
		c = getchar()(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])));
		/* Can't use digits in real time mode, or digit/ESC
		 * is an effective way to stop the game.
		 */
		if (isdigit(c)) {
			Count = (c - '0');
			while (isdigit(c = getchar()(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])))))
				Count = Count * 10 + (c - '0');
			if (c == ESC'\033')
				goto over;
			Cnt_move = c;
			if (Count)
				leaveok(stdscr, TRUE1);
		}
	}
}

switch (c) {
9
←
Control jumps to 'case 110:'  at line 158→
  case ' ':
  case '.':
	if (do_move(0, 0))
		goto ret;
	break;
  case 'y':
	if (do_move(-1, -1))
		goto ret;
	break;
  case 'k':
	if (do_move(-1, 0))
		goto ret;
	break;
  case 'u':
	if (do_move(-1, 1))
		goto ret;
	break;
  case 'h':
	if (do_move(0, -1))
		goto ret;
	break;
  case 'l':
	if (do_move(0, 1))
		goto ret;
	break;
  case 'b':
	if (do_move(1, -1))
		goto ret;
	break;
  case 'j':
	if (do_move(1, 0))
		goto ret;
	break;
  case 'n':
	if (do_move(1, 1))
10
←
Assuming the condition is false→
11
←
Taking false branch→
		goto ret;
	break;
12
←
 Execution continues on line 208→
  case 'Y': case 'U': case 'H': case 'J':
  case 'K': case 'L': case 'B': case 'N':
  case '>':
	Running = TRUE1;
	if (c == '>')
		Run_ch = ' ';
	else
		Run_ch = tolower(c);
	leaveok(stdscr, TRUE1);
	break;
  case 'q':
  case 'Q':
	if (query("Really quit?"))
		quit(0);
	refresh()wrefresh(stdscr);
	break;
  case 'w':
  case 'W':
	Waiting = TRUE1;
	leaveok(stdscr, TRUE1);
182#ifndef NCURSES_VERSION"5.7"
	flushok(stdscr, FALSE0);
184#endif
	goto ret;
  case 't':
  case 'T':
188teleport:
	Running = FALSE0;
	mvaddch(My_pos.y, My_pos.x, ' ')(wmove(stdscr,My_pos.y,My_pos.x) == (-1) ? (-1) : waddch(stdscr
,' '));
	My_pos = *rnd_pos();
	mvaddch(My_pos.y, My_pos.x, PLAYER)(wmove(stdscr,My_pos.y,My_pos.x) == (-1) ? (-1) : waddch(stdscr
,'@'));
	leaveok(stdscr, FALSE0);
	refresh()wrefresh(stdscr);
	flushinp();
	goto ret;
  case CTRL('L')('L'&037):
	wrefresh(curscr);
	break;
  case EOF(-1):
	quit(0);
	break;
  default:
	beep();
	reset_count();
	break;
}
if (Real_time) {
13
←
Assuming 'Real_time' is true→
14
←
Taking true branch→
	/* Update current time. */
	clock_gettime(CLOCK_MONOTONIC3, &t);

	/* Check whether tv time has passed. */
	timespecadd(&tn, &tv, &tn)do { (&tn)->tv_sec = (&tn)->tv_sec + (&tv)->
tv_sec; (&tn)->tv_nsec = (&tn)->tv_nsec + (&
tv)->tv_nsec; if ((&tn)->tv_nsec >= 1000000000L)
 { (&tn)->tv_sec++; (&tn)->tv_nsec -= 1000000000L
; } } while (0);
15
←
The left operand of '+' is a garbage value
	if (timespeccmp(&tn, &t, <)(((&tn)->tv_sec == (&t)->tv_sec) ? ((&tn)->
tv_nsec < (&t)->tv_nsec) : ((&tn)->tv_sec <
 (&t)->tv_sec)))
		goto ret;

	/* Keep the difference otherwise. */
	timespecsub(&tn, &t, &t)do { (&t)->tv_sec = (&tn)->tv_sec - (&t)->
tv_sec; (&t)->tv_nsec = (&tn)->tv_nsec - (&
t)->tv_nsec; if ((&t)->tv_nsec < 0) { (&t)->
tv_sec--; (&t)->tv_nsec += 1000000000L; } } while (0);
}
}
221ret:
if (Count > 0)
if (--Count == 0)
	leaveok(stdscr, FALSE0);
225}

227/*
* must_telep:
*	Must I teleport; i.e., is there anywhere I can move without
* being eaten?
*/
232bool_Bool
233must_telep(void)
234{
int		x, y;
static COORD	newpos;

238#ifdef	FANCY
if (Stand_still && Num_robots > 1 && eaten(&My_pos))
return TRUE1;
241#endif

for (y = -1; y <= 1; y++) {
newpos.y = My_pos.y + y;
if (newpos.y <= 0 || newpos.y >= Y_FIELDSIZE23)
	continue;
for (x = -1; x <= 1; x++) {
	newpos.x = My_pos.x + x;
	if (newpos.x <= 0 || newpos.x >= X_FIELDSIZE60)
		continue;
	if (Field[newpos.y][newpos.x] > 0)
		continue;
	if (!eaten(&newpos))
		return FALSE0;
}
}
return TRUE1;
258}

260/*
* do_move:
*	Execute a move
*/
264bool_Bool
265do_move(int dy, int dx)
266{
static COORD	newpos;

newpos.y = My_pos.y + dy;
newpos.x = My_pos.x + dx;
if (newpos.y <= 0 || newpos.y >= Y_FIELDSIZE23 ||
   newpos.x <= 0 || newpos.x >= X_FIELDSIZE60 ||
   Field[newpos.y][newpos.x] > 0 || eaten(&newpos)) {
if (Running) {
	Running = FALSE0;
	leaveok(stdscr, FALSE0);
	move(My_pos.y, My_pos.x)wmove(stdscr,My_pos.y,My_pos.x);
	refresh()wrefresh(stdscr);
} else {
	beep();
	reset_count();
}
return FALSE0;
}
else if (dy == 0 && dx == 0)
return TRUE1;
mvaddch(My_pos.y, My_pos.x, ' ')(wmove(stdscr,My_pos.y,My_pos.x) == (-1) ? (-1) : waddch(stdscr
,' '));
My_pos = newpos;
mvaddch(My_pos.y, My_pos.x, PLAYER)(wmove(stdscr,My_pos.y,My_pos.x) == (-1) ? (-1) : waddch(stdscr
,'@'));
if (!jumping())
refresh()wrefresh(stdscr);
return TRUE1;
293}

295/*
* eaten:
*	Player would get eaten at this place
*/
299bool_Bool
300eaten(COORD *pos)
301{
int	x, y;

for (y = pos->y - 1; y <= pos->y + 1; y++) {
if (y <= 0 || y >= Y_FIELDSIZE23)
	continue;
for (x = pos->x - 1; x <= pos->x + 1; x++) {
	if (x <= 0 || x >= X_FIELDSIZE60)
		continue;
	if (Field[y][x] == 1)
		return TRUE1;
}
}
return FALSE0;
315}

317/*
* reset_count:
*	Reset the count variables
*/
321void
322reset_count(void)
323{
Count = 0;
Running = FALSE0;
leaveok(stdscr, FALSE0);
refresh()wrefresh(stdscr);
328}

330/*
* jumping:
*	See if we are jumping, i.e., we should not refresh.
*/
334bool_Bool
335jumping(void)
336{
return (Jump && (Count || Running || Waiting));
338}