Bug Summary

File:src/usr.bin/grep/grep.c
Warning:line 420, column 8
Null pointer passed as 2nd argument to string comparison function

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name grep.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.bin/grep/obj -resource-dir /usr/local/lib/clang/13.0.0 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.bin/grep/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/usr.bin/grep/grep.c
1/* $OpenBSD: grep.c,v 1.65 2020/07/23 20:19:27 martijn Exp $ */
2
3/*-
4 * Copyright (c) 1999 James Howard and Dag-Erling Coïdan Smørgrav
5 * All rights reserved.
6 *
7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions
9 * are met:
10 * 1. Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
12 * 2. Redistributions in binary form must reproduce the above copyright
13 * notice, this list of conditions and the following disclaimer in the
14 * documentation and/or other materials provided with the distribution.
15 *
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
17 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
18 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
19 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
20 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
21 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
22 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
23 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
24 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
25 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
26 * SUCH DAMAGE.
27 */
28
29#include <sys/types.h>
30#include <sys/stat.h>
31#include <sys/queue.h>
32
33#include <ctype.h>
34#include <err.h>
35#include <errno(*__errno()).h>
36#include <getopt.h>
37#include <regex.h>
38#include <stdio.h>
39#include <stdlib.h>
40#include <string.h>
41#include <unistd.h>
42
43#include "grep.h"
44
45/* Flags passed to regcomp() and regexec() */
46int cflags;
47int eflags = REG_STARTEND00004;
48
49int matchall; /* shortcut */
50int patterns, pattern_sz;
51char **pattern;
52regex_t *r_pattern;
53fastgrep_t *fg_pattern;
54
55/* For regex errors */
56char re_error[RE_ERROR_BUF512 + 1];
57
58/* Command-line flags */
59int Aflag; /* -A x: print x lines trailing each match */
60int Bflag; /* -B x: print x lines leading each match */
61int Eflag; /* -E: interpret pattern as extended regexp */
62int Fflag; /* -F: interpret pattern as list of fixed strings */
63int Hflag; /* -H: always print filename header */
64int Lflag; /* -L: only show names of files with no matches */
65int Rflag; /* -R: recursively search directory trees */
66int Zflag; /* -Z: decompress input before processing */
67int bflag; /* -b: show block numbers for each match */
68int cflag; /* -c: only show a count of matching lines */
69int hflag; /* -h: don't print filename headers */
70int iflag; /* -i: ignore case */
71int lflag; /* -l: only show names of files with matches */
72int mflag; /* -m x: stop reading the files after x matches */
73long long mcount; /* count for -m */
74long long mlimit; /* requested value for -m */
75int nflag; /* -n: show line numbers in front of matching lines */
76int oflag; /* -o: print each match */
77int qflag; /* -q: quiet mode (don't output anything) */
78int sflag; /* -s: silent mode (ignore errors) */
79int vflag; /* -v: only show non-matching lines */
80int wflag; /* -w: pattern must start and end on word boundaries */
81int xflag; /* -x: pattern must match entire line */
82int lbflag; /* --line-buffered */
83const char *labelname; /* --label=name */
84
85int binbehave = BIN_FILE_BIN0;
86
87enum {
88 BIN_OPT = CHAR_MAX127 + 1,
89 HELP_OPT,
90 MMAP_OPT,
91 LINEBUF_OPT,
92 LABEL_OPT,
93};
94
95/* Housekeeping */
96int first; /* flag whether or not this is our first match */
97int tail; /* lines left to print */
98int file_err; /* file reading error */
99
100struct patfile {
101 const char *pf_file;
102 SLIST_ENTRY(patfile)struct { struct patfile *sle_next; } pf_next;
103};
104SLIST_HEAD(, patfile)struct { struct patfile *slh_first; } patfilelh;
105
106extern char *__progname;
107
108static void
109usage(void)
110{
111 fprintf(stderr(&__sF[2]),
112#ifdef NOZ
113 "usage: %s [-abcEFGHhIiLlnoqRsUVvwx] [-A num] [-B num] [-C[num]]"
114#else
115 "usage: %s [-abcEFGHhIiLlnoqRsUVvwxZ] [-A num] [-B num] [-C[num]]"
116#endif
117 " [-e pattern]\n"
118 "\t[-f file] [-m num] [--binary-files=value] [--context[=num]]\n"
119 "\t[--label=name] [--line-buffered] [pattern] [file ...]\n",
120 __progname);
121 exit(2);
122}
123
124#ifdef NOZ
125static const char optstr[] = "0123456789A:B:CEFGHILRUVabce:f:hilm:noqrsuvwxy";
126#else
127static const char optstr[] = "0123456789A:B:CEFGHILRUVZabce:f:hilm:noqrsuvwxy";
128#endif
129
130static const struct option long_options[] =
131{
132 {"binary-files", required_argument1, NULL((void*)0), BIN_OPT},
133 {"help", no_argument0, NULL((void*)0), HELP_OPT},
134 {"mmap", no_argument0, NULL((void*)0), MMAP_OPT},
135 {"label", required_argument1, NULL((void*)0), LABEL_OPT},
136 {"line-buffered", no_argument0, NULL((void*)0), LINEBUF_OPT},
137 {"after-context", required_argument1, NULL((void*)0), 'A'},
138 {"before-context", required_argument1, NULL((void*)0), 'B'},
139 {"context", optional_argument2, NULL((void*)0), 'C'},
140 {"devices", required_argument1, NULL((void*)0), 'D'},
141 {"extended-regexp", no_argument0, NULL((void*)0), 'E'},
142 {"fixed-strings", no_argument0, NULL((void*)0), 'F'},
143 {"basic-regexp", no_argument0, NULL((void*)0), 'G'},
144 {"with-filename", no_argument0, NULL((void*)0), 'H'},
145 {"binary", no_argument0, NULL((void*)0), 'U'},
146 {"version", no_argument0, NULL((void*)0), 'V'},
147 {"text", no_argument0, NULL((void*)0), 'a'},
148 {"byte-offset", no_argument0, NULL((void*)0), 'b'},
149 {"count", no_argument0, NULL((void*)0), 'c'},
150 {"regexp", required_argument1, NULL((void*)0), 'e'},
151 {"file", required_argument1, NULL((void*)0), 'f'},
152 {"no-filename", no_argument0, NULL((void*)0), 'h'},
153 {"ignore-case", no_argument0, NULL((void*)0), 'i'},
154 {"files-without-match", no_argument0, NULL((void*)0), 'L'},
155 {"files-with-matches", no_argument0, NULL((void*)0), 'l'},
156 {"max-count", required_argument1, NULL((void*)0), 'm'},
157 {"line-number", no_argument0, NULL((void*)0), 'n'},
158 {"quiet", no_argument0, NULL((void*)0), 'q'},
159 {"silent", no_argument0, NULL((void*)0), 'q'},
160 {"recursive", no_argument0, NULL((void*)0), 'r'},
161 {"no-messages", no_argument0, NULL((void*)0), 's'},
162 {"revert-match", no_argument0, NULL((void*)0), 'v'},
163 {"word-regexp", no_argument0, NULL((void*)0), 'w'},
164 {"line-regexp", no_argument0, NULL((void*)0), 'x'},
165 {"unix-byte-offsets", no_argument0, NULL((void*)0), 'u'},
166#ifndef NOZ
167 {"decompress", no_argument0, NULL((void*)0), 'Z'},
168#endif
169 {NULL((void*)0), no_argument0, NULL((void*)0), 0}
170};
171
172
173static void
174add_pattern(char *pat, size_t len)
175{
176 if (!xflag && (len == 0 || matchall)) {
177 matchall = 1;
178 return;
179 }
180 if (patterns == pattern_sz) {
181 pattern_sz *= 2;
182 pattern = grep_reallocarray(pattern, ++pattern_sz, sizeof(*pattern));
183 }
184 if (len > 0 && pat[len - 1] == '\n')
185 --len;
186 /* pat may not be NUL-terminated */
187 if (wflag && !Fflag) {
188 int bol = 0, eol = 0, extra;
189 if (pat[0] == '^')
190 bol = 1;
191 if (len > 0 && pat[len - 1] == '$')
192 eol = 1;
193 extra = Eflag ? 2 : 4;
194 pattern[patterns] = grep_malloc(len + 15 + extra);
195 snprintf(pattern[patterns], len + 15 + extra,
196 "%s[[:<:]]%s%.*s%s[[:>:]]%s",
197 bol ? "^" : "",
198 Eflag ? "(" : "\\(",
199 (int)len - bol - eol, pat + bol,
200 Eflag ? ")" : "\\)",
201 eol ? "$" : "");
202 len += 14 + extra;
203 } else {
204 pattern[patterns] = grep_malloc(len + 1);
205 memcpy(pattern[patterns], pat, len);
206 pattern[patterns][len] = '\0';
207 }
208 ++patterns;
209}
210
211static void
212add_patterns(char *pats)
213{
214 char *nl;
215
216 while ((nl = strchr(pats, '\n')) != NULL((void*)0)) {
217 add_pattern(pats, nl - pats);
218 pats = nl + 1;
219 }
220 add_pattern(pats, strlen(pats));
221}
222
223static void
224read_patterns(const char *fn)
225{
226 FILE *f;
227 char *line;
228 ssize_t len;
229 size_t linesize;
230
231 if ((f = fopen(fn, "r")) == NULL((void*)0))
232 err(2, "%s", fn);
233 line = NULL((void*)0);
234 linesize = 0;
235 while ((len = getline(&line, &linesize, f)) != -1)
236 add_pattern(line, *line == '\n' ? 0 : len);
237 if (ferror(f)(!__isthreaded ? (((f)->_flags & 0x0040) != 0) : (ferror
)(f)))
238 err(2, "%s", fn);
239 fclose(f);
240 free(line);
241}
242
243int
244main(int argc, char *argv[])
245{
246 int c, lastc, prevoptind, newarg, i, needpattern, exprs, expr_sz;
247 struct patfile *patfile, *pf_next;
248 long l;
249 char **expr;
250 const char *errstr;
251
252 if (pledge("stdio rpath", NULL((void*)0)) == -1)
1
Assuming the condition is false
→
2
←
Taking false branch
→
253 err(2, "pledge");
254
255 SLIST_INIT(&patfilelh){ ((&patfilelh)->slh_first) = ((void*)0); };
256 switch (__progname[0]) {
3
←
'Default' branch taken. Execution continues on line 278
→
257 case 'e':
258 Eflag = 1;
259 break;
260 case 'f':
261 Fflag = 1;
262 break;
263#ifndef NOZ
264 case 'z':
265 Zflag = 1;
266 switch(__progname[1]) {
267 case 'e':
268 Eflag = 1;
269 break;
270 case 'f':
271 Fflag = 1;
272 break;
273 }
274 break;
275#endif
276 }
277
278 lastc = '\0';
279 newarg = 1;
280 prevoptind = 1;
281 needpattern = 1;
282 expr_sz = exprs = 0;
283 expr = NULL((void*)0);
284 while ((c = getopt_long(argc, argv, optstr,
4
←
Assuming the condition is true
→
5
←
Loop condition is true. Entering loop body
→
11
←
Assuming the condition is true
→
12
←
Loop condition is true. Entering loop body
→
285 long_options, NULL((void*)0))) != -1) {
286 switch (c) {
6
←
Control jumps to 'case 67:' at line 305
→
13
←
Control jumps to 'case BIN_OPT:' at line 419
→
287 case '0': case '1': case '2': case '3': case '4':
288 case '5': case '6': case '7': case '8': case '9':
289 if (newarg || !isdigit(lastc))
290 Aflag = 0;
291 else if (Aflag > INT_MAX2147483647 / 10)
292 errx(2, "context out of range");
293 Aflag = Bflag = (Aflag * 10) + (c - '0');
294 break;
295 case 'A':
296 case 'B':
297 l = strtonum(optarg, 1, INT_MAX2147483647, &errstr);
298 if (errstr != NULL((void*)0))
299 errx(2, "context %s", errstr);
300 if (c == 'A')
301 Aflag = (int)l;
302 else
303 Bflag = (int)l;
304 break;
305 case 'C':
306 if (optarg == NULL((void*)0))
7
←
Assuming 'optarg' is equal to NULL
→
8
←
Taking true branch
→
307 Aflag = Bflag = 2;
308 else {
309 l = strtonum(optarg, 1, INT_MAX2147483647, &errstr);
310 if (errstr != NULL((void*)0))
311 errx(2, "context %s", errstr);
312 Aflag = Bflag = (int)l;
313 }
314 break;
9
←
 Execution continues on line 443
→
315 case 'E':
316 Fflag = 0;
317 Eflag = 1;
318 break;
319 case 'F':
320 Eflag = 0;
321 Fflag = 1;
322 break;
323 case 'G':
324 Eflag = Fflag = 0;
325 break;
326 case 'H':
327 Hflag = 1;
328 break;
329 case 'I':
330 binbehave = BIN_FILE_SKIP1;
331 break;
332 case 'L':
333 lflag = 0;
334 Lflag = qflag = 1;
335 break;
336 case 'R':
337 case 'r':
338 Rflag = 1;
339 break;
340 case 'U':
341 binbehave = BIN_FILE_BIN0;
342 break;
343 case 'V':
344 fprintf(stderr(&__sF[2]), "grep version %u.%u\n", VER_MAJ0, VER_MIN9);
345 exit(0);
346 break;
347#ifndef NOZ
348 case 'Z':
349 Zflag = 1;
350 break;
351#endif
352 case 'a':
353 binbehave = BIN_FILE_TEXT2;
354 break;
355 case 'b':
356 bflag = 1;
357 break;
358 case 'c':
359 cflag = 1;
360 break;
361 case 'e':
362 /* defer adding of expressions until all arguments are parsed */
363 if (exprs == expr_sz) {
364 expr_sz *= 2;
365 expr = grep_reallocarray(expr, ++expr_sz,
366 sizeof(*expr));
367 }
368 needpattern = 0;
369 expr[exprs] = optarg;
370 ++exprs;
371 break;
372 case 'f':
373 patfile = grep_malloc(sizeof(*patfile));
374 patfile->pf_file = optarg;
375 SLIST_INSERT_HEAD(&patfilelh, patfile, pf_next)do { (patfile)->pf_next.sle_next = (&patfilelh)->slh_first
; (&patfilelh)->slh_first = (patfile); } while (0);
376 needpattern = 0;
377 break;
378 case 'h':
379 hflag = 1;
380 break;
381 case 'i':
382 case 'y':
383 iflag = 1;
384 cflags |= REG_ICASE0002;
385 break;
386 case 'l':
387 Lflag = 0;
388 lflag = qflag = 1;
389 break;
390 case 'm':
391 mflag = 1;
392 mlimit = mcount = strtonum(optarg, 0, LLONG_MAX9223372036854775807LL,
393 &errstr);
394 if (errstr != NULL((void*)0))
395 errx(2, "invalid max-count %s: %s",
396 optarg, errstr);
397 break;
398 case 'n':
399 nflag = 1;
400 break;
401 case 'o':
402 oflag = 1;
403 break;
404 case 'q':
405 qflag = 1;
406 break;
407 case 's':
408 sflag = 1;
409 break;
410 case 'v':
411 vflag = 1;
412 break;
413 case 'w':
414 wflag = 1;
415 break;
416 case 'x':
417 xflag = 1;
418 break;
419 case BIN_OPT:
420 if (strcmp("binary", optarg) == 0)
14
←
Null pointer passed as 2nd argument to string comparison function
421 binbehave = BIN_FILE_BIN0;
422 else if (strcmp("without-match", optarg) == 0)
423 binbehave = BIN_FILE_SKIP1;
424 else if (strcmp("text", optarg) == 0)
425 binbehave = BIN_FILE_TEXT2;
426 else
427 errx(2, "Unknown binary-files option");
428 break;
429 case 'u':
430 case MMAP_OPT:
431 /* default, compatibility */
432 break;
433 case LABEL_OPT:
434 labelname = optarg;
435 break;
436 case LINEBUF_OPT:
437 lbflag = 1;
438 break;
439 case HELP_OPT:
440 default:
441 usage();
442 }
443 lastc = c;
444 newarg = optind != prevoptind;
10
←
Assuming 'optind' is equal to 'prevoptind'
→
445 prevoptind = optind;
446 }
447 argc -= optind;
448 argv += optind;
449
450 for (i = 0; i < exprs; i++)
451 add_patterns(expr[i]);
452 free(expr);
453 expr = NULL((void*)0);
454
455 for (patfile = SLIST_FIRST(&patfilelh)((&patfilelh)->slh_first); patfile != NULL((void*)0);
456 patfile = pf_next) {
457 pf_next = SLIST_NEXT(patfile, pf_next)((patfile)->pf_next.sle_next);
458 read_patterns(patfile->pf_file);
459 free(patfile);
460 }
461
462 if (argc == 0 && needpattern)
463 usage();
464
465 if (argc != 0 && needpattern) {
466 add_patterns(*argv);
467 --argc;
468 ++argv;
469 }
470 if (argc == 1 && strcmp(*argv, "-") == 0) {
471 /* stdin */
472 --argc;
473 ++argv;
474 }
475
476 if (Eflag)
477 cflags |= REG_EXTENDED0001;
478 if (Fflag)
479 cflags |= REG_NOSPEC0020;
480#ifdef SMALL
481 /* Sorry, this won't work */
482 if (Fflag && wflag)
483 errx(1, "Can't use small fgrep with -w");
484#endif
485 fg_pattern = grep_calloc(patterns, sizeof(*fg_pattern));
486 r_pattern = grep_calloc(patterns, sizeof(*r_pattern));
487 for (i = 0; i < patterns; ++i) {
488 /* Check if cheating is allowed (always is for fgrep). */
489#ifndef SMALL
490 if (Fflag) {
491 fgrepcomp(&fg_pattern[i], pattern[i]);
492 } else
493#endif
494 {
495 if (fastcomp(&fg_pattern[i], pattern[i])) {
496 /* Fall back to full regex library */
497 c = regcomp(&r_pattern[i], pattern[i], cflags);
498 if (c != 0) {
499 regerror(c, &r_pattern[i], re_error,
500 RE_ERROR_BUF512);
501 errx(2, "%s", re_error);
502 }
503 }
504 }
505 }
506
507 if (lbflag)
508 setvbuf(stdout(&__sF[1]), NULL((void*)0), _IOLBF1, 0);
509
510 if ((argc == 0 || argc == 1) && !Rflag && !Hflag)
511 hflag = 1;
512
513 if (argc == 0 && !Rflag)
514 exit(!procfile(NULL((void*)0)));
515
516 if (Rflag)
517 c = grep_tree(argv);
518 else
519 for (c = 0; argc--; ++argv)
520 c |= procfile(*argv);
521
522 exit(c ? (file_err ? (qflag ? 0 : 2) : 0) : (file_err ? 2 : 1));
523}