/usr/src/usr.bin/rcs/rcsutil.c

Bug Summary

File:	src/usr.bin/rcs/rcsutil.c
Warning:	line 263, column 6 Null pointer passed as 2nd argument to string concatenation function

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.4 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name rcsutil.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.bin/rcs/obj -resource-dir /usr/local/llvm16/lib/clang/16 -I /usr/src/usr.bin/rcs -internal-isystem /usr/local/llvm16/lib/clang/16/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.bin/rcs/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fcf-protection=branch -fno-jump-tables -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/scan/2024-01-11-140451-98009-1 -x c /usr/src/usr.bin/rcs/rcsutil.c

1/*	$OpenBSD: rcsutil.c,v 1.48 2023/08/11 05:02:21 guenther Exp $	*/
2/*
* Copyright (c) 2005, 2006 Joris Vink <joris@openbsd.org>
* Copyright (c) 2006 Xavier Santolaria <xsa@openbsd.org>
* Copyright (c) 2006 Niall O'Higgins <niallo@openbsd.org>
* Copyright (c) 2006 Ray Lai <ray@openbsd.org>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*    notice, this list of conditions and the following disclaimer.
* 2. The name of the author may not be used to endorse or promote products
*    derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
* AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
* THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL  DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
* OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
* OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

30#include <sys/stat.h>
31#include <sys/time.h>

33#include <ctype.h>
34#include <err.h>
35#include <fcntl.h>
36#include <stdio.h>
37#include <stdlib.h>
38#include <string.h>
39#include <unistd.h>

41#include "rcsprog.h"

43/*
* rcs_get_mtime()
*
* Get <filename> last modified time.
* Returns last modified time on success, or a timespec with tv_nsec
* set to UTIME_OMIT on failure.
*/
50struct timespec
51rcs_get_mtime(RCSFILE *file)
52{
struct stat st;
struct timespec mtime = { .tv_sec = 0, .tv_nsec = UTIME_OMIT-1L };

if (file->rf_file == NULL((void *)0))
return mtime;

if (fstat(fileno(file->rf_file)(!__isthreaded ? ((file->rf_file)->_file) : (fileno)(file
->rf_file)), &st) == -1) {
warn("%s", file->rf_path);
return mtime;
}

return st.st_mtim;
65}

67/*
* rcs_set_mtime()
*
* Set <filename> last modified time to <mtime> if its tv_nsec isn't UTIME_OMIT
*/
72void
73rcs_set_mtime(RCSFILE *file, struct timespec mtime)
74{
struct timespec ts[2];

if (file->rf_file == NULL((void *)0) || mtime.tv_nsec == UTIME_OMIT-1L)
return;

ts[0] = ts[1] = mtime;

if (futimens(fileno(file->rf_file)(!__isthreaded ? ((file->rf_file)->_file) : (fileno)(file
->rf_file)), ts) == -1)
err(1, "utimes");
84}

86int
87rcs_getopt(int argc, char **argv, const char *optstr)
88{
char *a;
const char *c;
static int i = 1;
int opt, hasargument, ret;

hasargument = 0;
rcs_optarg = NULL((void *)0);

if (i >= argc)
return (-1);

a = argv[i++];
if (*a++ != '-')
return (-1);

ret = 0;
opt = *a;
for (c = optstr; *c != '\0'; c++) {
if (*c == opt) {
	a++;
	ret = opt;

	if (*(c + 1) == ':') {
		if (*(c + 2) == ':') {
			if (*a != '\0')
				hasargument = 1;
		} else {
			if (*a != '\0') {
				hasargument = 1;
			} else {
				ret = 1;
				break;
			}
		}
	}

	if (hasargument == 1)
		rcs_optarg = a;

	if (ret == opt)
		rcs_optind++;
	break;
}
}

if (ret == 0)
warnx("unknown option -%c", opt);
else if (ret == 1)
warnx("missing argument for option -%c", opt);

return (ret);
140}

142/*
* rcs_choosefile()
*
* Given a relative filename, decide where the corresponding RCS file
* should be.  Tries each extension until a file is found.  If no file
* was found, returns a path with the first extension.
*
* Opens and returns file descriptor to RCS file.
*/
151int
152rcs_choosefile(const char *filename, char *out, size_t len)
153{
int fd;
struct stat sb;
char *p, *ext, name[PATH_MAX1024], *next, *ptr, rcsdir[PATH_MAX1024],
   *suffixes, rcspath[PATH_MAX1024];

/*
* If `filename' contains a directory, `rcspath' contains that
* directory, including a trailing slash.  Otherwise `rcspath'
* contains an empty string.
*/
if (strlcpy(rcspath, filename, sizeof(rcspath)) >= sizeof(rcspath))
1
Assuming the condition is false→
2
←
Taking false branch→
errx(1, "rcs_choosefile: truncation");

/* If `/' is found, end string after `/'. */
if ((ptr = strrchr(rcspath, '/')) != NULL((void *)0))
3
←
Assuming the condition is false→
4
←
Taking false branch→
*(++ptr) = '\0';
else
rcspath[0] = '\0';

/* Append RCS/ to `rcspath' if it exists. */
if (strlcpy(rcsdir, rcspath, sizeof(rcsdir)) >= sizeof(rcsdir) ||
5
←
Assuming the condition is false→
   strlcat(rcsdir, RCSDIR"RCS", sizeof(rcsdir)) >= sizeof(rcsdir))
6
←
Assuming the condition is false→
errx(1, "rcs_choosefile: truncation");

if (stat(rcsdir, &sb) == 0 && S_ISDIR(sb.st_mode)((sb.st_mode & 0170000) == 0040000))
7
←
Assuming the condition is false→
if (strlcpy(rcspath, rcsdir, sizeof(rcspath))
    >= sizeof(rcspath) ||
    strlcat(rcspath, "/", sizeof(rcspath)) >= sizeof(rcspath))
	errx(1, "rcs_choosefile: truncation");

/* Name of file without path. */
if ((ptr = strrchr(filename, '/')) == NULL((void *)0)) {
8
←
Assuming the condition is true→
9
←
Taking true branch→
if (strlcpy(name, filename, sizeof(name)) >= sizeof(name))
10
←
Taking false branch→
	errx(1, "rcs_choosefile: truncation");
} else {
/* Skip `/'. */
if (strlcpy(name, ptr + 1, sizeof(name)) >= sizeof(name))
	errx(1, "rcs_choosefile: truncation");
}

/* Name of RCS file without an extension. */
if (strlcat(rcspath, name, sizeof(rcspath)) >= sizeof(rcspath))
11
←
Assuming the condition is false→
12
←
Taking false branch→
errx(1, "rcs_choosefile: truncation");

/*
* If only the empty suffix was given, use existing rcspath.
* This ensures that there is at least one suffix for strsep().
*/
if (strcmp(rcs_suffixes, "") == 0) {
13
←
Assuming the condition is false→
14
←
Taking false branch→
if (strlcpy(out, rcspath, len) >= len)
	errx(1, "rcs_choosefile: truncation");
fd = open(rcspath, O_RDONLY0x0000);
return (fd);
}

/*
* Cycle through slash-separated `rcs_suffixes', appending each
* extension to `rcspath' and testing if the file exists.  If it
* does, return that string.  Otherwise return path with first
* extension.
*/
suffixes = xstrdup(rcs_suffixes);
15
←
Value assigned to 'suffixes'→
for (next = suffixes; (ext = strsep(&next, "/")) != NULL((void *)0);) {
16
←
Assuming pointer value is null→
17
←
Loop condition is false. Execution continues on line 263→
char fpath[PATH_MAX1024];

if ((p = strrchr(rcspath, ',')) != NULL((void *)0)) {
	if (!strcmp(p, ext)) {
		if ((fd = open(rcspath, O_RDONLY0x0000)) == -1)
			continue;

		if (fstat(fd, &sb) == -1)
			err(1, "%s", rcspath);

		if (strlcpy(out, rcspath, len) >= len)
			errx(1, "rcs_choosefile: truncation");

		free(suffixes);
		return (fd);
	}

	continue;
}

/* Construct RCS file path. */
if (strlcpy(fpath, rcspath, sizeof(fpath)) >= sizeof(fpath) ||
    strlcat(fpath, ext, sizeof(fpath)) >= sizeof(fpath))
	errx(1, "rcs_choosefile: truncation");

/* Don't use `filename' as RCS file. */
if (strcmp(fpath, filename) == 0)
	continue;

if ((fd = open(fpath, O_RDONLY0x0000)) == -1)
	continue;

if (fstat(fd, &sb) == -1)
	err(1, "%s", fpath);

if (strlcpy(out, fpath, len) >= len)
	errx(1, "rcs_choosefile: truncation");

free(suffixes);
return (fd);
}

/*
* `suffixes' should now be NUL separated, so the first
* extension can be read just by reading `suffixes'.
*/
if (strlcat(rcspath, suffixes, sizeof(rcspath)) >= sizeof(rcspath))
18
←
Null pointer passed as 2nd argument to string concatenation function
errx(1, "rcs_choosefile: truncation");

free(suffixes);

if (strlcpy(out, rcspath, len) >= len)
errx(1, "rcs_choosefile: truncation");

fd = open(rcspath, O_RDONLY0x0000);

return (fd);
274}

276/*
* Set <str> to <new_str>.  Print warning if <str> is redefined.
*/
279void
280rcs_setrevstr(char **str, char *new_str)
281{
if (new_str == NULL((void *)0))
return;
if (*str != NULL((void *)0))
warnx("redefinition of revision number");
*str = new_str;
287}

289/*
* Set <str1> or <str2> to <new_str>, depending on which is not set.
* If both are set, error out.
*/
293void
294rcs_setrevstr2(char **str1, char **str2, char *new_str)
295{
if (new_str == NULL((void *)0))
return;
if (*str1 == NULL((void *)0))
*str1 = new_str;
else if (*str2 == NULL((void *)0))
*str2 = new_str;
else
errx(1, "too many revision numbers");
304}

306/*
* Get revision from file.  The revision can be specified as a symbol or
* a revision number.
*/
310RCSNUM *
311rcs_getrevnum(const char *rev_str, RCSFILE *file)
312{
RCSNUM *rev;

/* Search for symbol. */
rev = rcs_sym_getrev(file, rev_str);

/* Search for revision number. */
if (rev == NULL((void *)0))
rev = rcsnum_parse(rev_str);

return (rev);
323}

325/*
* Prompt for and store user's input in an allocated string.
*
* Returns the string's pointer.
*/
330char *
331rcs_prompt(const char *prompt, int flags)
332{
BUF *bp;
size_t len;
char *buf;

if (!(flags & INTERACTIVE(1<<20)) && isatty(STDIN_FILENO0))
flags |= INTERACTIVE(1<<20);

bp = buf_alloc(0);
if (flags & INTERACTIVE(1<<20))
(void)fprintf(stderr(&__sF[2]), "%s", prompt);
if (flags & INTERACTIVE(1<<20))
(void)fprintf(stderr(&__sF[2]), ">> ");
clearerr(stdin)(!__isthreaded ? ((void)(((&__sF[0]))->_flags &= ~
(0x0040|0x0020))) : (clearerr)((&__sF[0])));
while ((buf = fgetln(stdin(&__sF[0]), &len)) != NULL((void *)0)) {
/* The last line may not be EOL terminated. */
if (buf[0] == '.' && (len == 1 || buf[1] == '\n'))
	break;
else
	buf_append(bp, buf, len);

if (flags & INTERACTIVE(1<<20))
	(void)fprintf(stderr(&__sF[2]), ">> ");
}
buf_putc(bp, '\0');

return (buf_release(bp));
359}

361u_int
362rcs_rev_select(RCSFILE *file, const char *range)
363{
int i;
u_int nrev;
const char *ep;
char *lstr, *rstr;
struct rcs_delta *rdp;
struct rcs_argvector *revargv, *revrange;
RCSNUM lnum, rnum;

nrev = 0;
(void)memset(&lnum, 0, sizeof(lnum));
(void)memset(&rnum, 0, sizeof(rnum));

if (range == NULL((void *)0)) {
TAILQ_FOREACH(rdp, &file->rf_delta, rd_list)for((rdp) = ((&file->rf_delta)->tqh_first); (rdp) !=
 ((void *)0); (rdp) = ((rdp)->rd_list.tqe_next))
	if (rcsnum_cmp(rdp->rd_num, file->rf_head, 0) == 0) {
		rdp->rd_flags |= RCS_RD_SELECT0x02;
		return (1);
	}
return (0);
}

revargv = rcs_strsplit(range, ",");
for (i = 0; revargv->argv[i] != NULL((void *)0); i++) {
revrange = rcs_strsplit(revargv->argv[i], ":");
if (revrange->argv[0] == NULL((void *)0))
	/* should not happen */
	errx(1, "invalid revision range: %s", revargv->argv[i]);
else if (revrange->argv[1] == NULL((void *)0))
	lstr = rstr = revrange->argv[0];
else {
	if (revrange->argv[2] != NULL((void *)0))
		errx(1, "invalid revision range: %s",
		    revargv->argv[i]);
	lstr = revrange->argv[0];
	rstr = revrange->argv[1];
	if (strcmp(lstr, "") == 0)
		lstr = NULL((void *)0);
	if (strcmp(rstr, "") == 0)
		rstr = NULL((void *)0);
}

if (lstr == NULL((void *)0))
	lstr = RCS_HEAD_INIT"1.1";
if (rcsnum_aton(lstr, &ep, &lnum) == 0 || (*ep != '\0'))
	errx(1, "invalid revision: %s", lstr);

if (rstr != NULL((void *)0)) {
	if (rcsnum_aton(rstr, &ep, &rnum) == 0 || (*ep != '\0'))
		errx(1, "invalid revision: %s", rstr);
} else
	rcsnum_cpy(file->rf_head, &rnum, 0);

rcs_argv_destroy(revrange);

TAILQ_FOREACH(rdp, &file->rf_delta, rd_list)for((rdp) = ((&file->rf_delta)->tqh_first); (rdp) !=
 ((void *)0); (rdp) = ((rdp)->rd_list.tqe_next))
	if (rcsnum_cmp(rdp->rd_num, &lnum, 0) <= 0 &&
	    rcsnum_cmp(rdp->rd_num, &rnum, 0) >= 0 &&
	    !(rdp->rd_flags & RCS_RD_SELECT0x02)) {
		rdp->rd_flags |= RCS_RD_SELECT0x02;
		nrev++;
	}
}
rcs_argv_destroy(revargv);

free(lnum.rn_id);
free(rnum.rn_id);

return (nrev);
432}

434/*
* Load description from <in> to <file>.
* If <in> starts with a `-', <in> is taken as the description.
* Otherwise <in> is the name of the file containing the description.
* If <in> is NULL, the description is read from stdin.
* Returns 0 on success, -1 on failure, setting errno.
*/
441int
442rcs_set_description(RCSFILE *file, const char *in, int flags)
443{
BUF *bp;
char *content;
const char *prompt =
   "enter description, terminated with single '.' or end of file:\n"
   "NOTE: This is NOT the log message!\n";

/* Description is in file <in>. */
if (in != NULL((void *)0) && *in != '-') {
if ((bp = buf_load(in)) == NULL((void *)0))
	return (-1);
buf_putc(bp, '\0');
content = buf_release(bp);
/* Description is in <in>. */
} else if (in != NULL((void *)0))
/* Skip leading `-'. */
content = xstrdup(in + 1);
/* Get description from stdin. */
else
content = rcs_prompt(prompt, flags);

rcs_desc_set(file, content);
free(content);
return (0);
467}

469/*
* Split the contents of a file into a list of lines.
*/
472struct rcs_lines *
473rcs_splitlines(u_char *data, size_t len)
474{
u_char *c, *p;
struct rcs_lines *lines;
struct rcs_line *lp;
size_t i, tlen;

lines = xcalloc(1, sizeof(*lines));
TAILQ_INIT(&(lines->l_lines))do { (&(lines->l_lines))->tqh_first = ((void *)0); (
&(lines->l_lines))->tqh_last = &(&(lines->
l_lines))->tqh_first; } while (0);

lp = xcalloc(1, sizeof(*lp));
TAILQ_INSERT_TAIL(&(lines->l_lines), lp, l_list)do { (lp)->l_list.tqe_next = ((void *)0); (lp)->l_list.
tqe_prev = (&(lines->l_lines))->tqh_last; *(&(lines
->l_lines))->tqh_last = (lp); (&(lines->l_lines)
)->tqh_last = &(lp)->l_list.tqe_next; } while (0);


p = c = data;
for (i = 0; i < len; i++) {
if (*p == '\n' || (i == len - 1)) {
	tlen = p - c + 1;
	lp = xmalloc(sizeof(*lp));
	lp->l_line = c;
	lp->l_len = tlen;
	lp->l_lineno = ++(lines->l_nblines);
	TAILQ_INSERT_TAIL(&(lines->l_lines), lp, l_list)do { (lp)->l_list.tqe_next = ((void *)0); (lp)->l_list.
tqe_prev = (&(lines->l_lines))->tqh_last; *(&(lines
->l_lines))->tqh_last = (lp); (&(lines->l_lines)
)->tqh_last = &(lp)->l_list.tqe_next; } while (0);
	c = p + 1;
}
p++;
}

return (lines);
502}

504void
505rcs_freelines(struct rcs_lines *lines)
506{
struct rcs_line *lp;

while ((lp = TAILQ_FIRST(&(lines->l_lines))((&(lines->l_lines))->tqh_first)) != NULL((void *)0)) {
TAILQ_REMOVE(&(lines->l_lines), lp, l_list)do { if (((lp)->l_list.tqe_next) != ((void *)0)) (lp)->
l_list.tqe_next->l_list.tqe_prev = (lp)->l_list.tqe_prev
; else (&(lines->l_lines))->tqh_last = (lp)->l_list
.tqe_prev; *(lp)->l_list.tqe_prev = (lp)->l_list.tqe_next
; ; ; } while (0);
free(lp);
}

free(lines);
515}

517BUF *
518rcs_patchfile(u_char *data, size_t dlen, u_char *patch, size_t plen,
  int (*p)(struct rcs_lines *, struct rcs_lines *))
520{
struct rcs_lines *dlines, *plines;
struct rcs_line *lp;
BUF *res;

dlines = rcs_splitlines(data, dlen);
plines = rcs_splitlines(patch, plen);

if (p(dlines, plines) < 0) {
rcs_freelines(dlines);
rcs_freelines(plines);
return (NULL((void *)0));
}

res = buf_alloc(1024);
TAILQ_FOREACH(lp, &dlines->l_lines, l_list)for((lp) = ((&dlines->l_lines)->tqh_first); (lp) !=
 ((void *)0); (lp) = ((lp)->l_list.tqe_next)) {
if (lp->l_line == NULL((void *)0))
	continue;
buf_append(res, lp->l_line, lp->l_len);
}

rcs_freelines(dlines);
rcs_freelines(plines);
return (res);
544}

546/*
* rcs_yesno()
*
* Read a char from standard input, returns defc if the
* user enters an equivalent to defc, else whatever char
* was entered.  Converts input to lower case.
*/
553int
554rcs_yesno(int defc)
555{
int c, ret;

fflush(stderr(&__sF[2]));
fflush(stdout(&__sF[1]));

clearerr(stdin)(!__isthreaded ? ((void)(((&__sF[0]))->_flags &= ~
(0x0040|0x0020))) : (clearerr)((&__sF[0])));
if (isalpha(c = getchar()(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])))))
c = tolower(c);
if (c == defc || c == '\n' || (c == EOF(-1) && feof(stdin)(!__isthreaded ? ((((&__sF[0]))->_flags & 0x0020) !=
 0) : (feof)((&__sF[0])))))
ret = defc;
else
ret = c;

while (c != EOF(-1) && c != '\n')
c = getchar()(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])));

return (ret);
573}

575/*
* rcs_strsplit()
*
* Split a string <str> of <sep>-separated values and allocate
* an argument vector for the values found.
*/
581struct rcs_argvector *
582rcs_strsplit(const char *str, const char *sep)
583{
struct rcs_argvector *av;
size_t i = 0;
char *cp, *p;

cp = xstrdup(str);
av = xmalloc(sizeof(*av));
av->str = cp;
av->argv = xmalloc(sizeof(*(av->argv)));

while ((p = strsep(&cp, sep)) != NULL((void *)0)) {
av->argv[i++] = p;
av->argv = xreallocarray(av->argv,
    i + 1, sizeof(*(av->argv)));
}
av->argv[i] = NULL((void *)0);

return (av);
601}

603/*
* rcs_argv_destroy()
*
* Free an argument vector previously allocated by rcs_strsplit().
*/
608void
609rcs_argv_destroy(struct rcs_argvector *av)
610{
free(av->str);
free(av->argv);
free(av);
614}

616/*
* Strip suffix from filename.
*/
619void
620rcs_strip_suffix(char *filename)
621{
char *p, *suffixes, *next, *ext;

if ((p = strrchr(filename, ',')) != NULL((void *)0)) {
suffixes = xstrdup(rcs_suffixes);
for (next = suffixes; (ext = strsep(&next, "/")) != NULL((void *)0);) {
	if (!strcmp(p, ext)) {
		*p = '\0';
		break;
	}
}
free(suffixes);
}
634}