Bug Summary

File:dev/pci/drm/i915/display/dvo_ch7xxx.c
Warning:line 262, column 11
The left operand of '&' is a garbage value

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.4 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name dvo_ch7xxx.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model static -mframe-pointer=all -relaxed-aliasing -ffp-contract=on -fno-rounding-math -mconstructor-aliases -ffreestanding -mcmodel=kernel -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -target-feature -sse2 -target-feature -sse -target-feature -3dnow -target-feature -mmx -target-feature +save-args -target-feature +retpoline-external-thunk -disable-red-zone -no-implicit-float -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -nostdsysteminc -nobuiltininc -resource-dir /usr/local/llvm16/lib/clang/16 -I /usr/src/sys -I /usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -I /usr/src/sys/arch -I /usr/src/sys/dev/pci/drm/include -I /usr/src/sys/dev/pci/drm/include/uapi -I /usr/src/sys/dev/pci/drm/amd/include/asic_reg -I /usr/src/sys/dev/pci/drm/amd/include -I /usr/src/sys/dev/pci/drm/amd/amdgpu -I /usr/src/sys/dev/pci/drm/amd/display -I /usr/src/sys/dev/pci/drm/amd/display/include -I /usr/src/sys/dev/pci/drm/amd/display/dc -I /usr/src/sys/dev/pci/drm/amd/display/amdgpu_dm -I /usr/src/sys/dev/pci/drm/amd/pm/inc -I /usr/src/sys/dev/pci/drm/amd/pm/legacy-dpm -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu11 -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu12 -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu13 -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/inc -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/hwmgr -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/smumgr -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc/pmfw_if -I /usr/src/sys/dev/pci/drm/amd/display/dc/inc -I /usr/src/sys/dev/pci/drm/amd/display/dc/inc/hw -I /usr/src/sys/dev/pci/drm/amd/display/dc/clk_mgr -I /usr/src/sys/dev/pci/drm/amd/display/modules/inc -I /usr/src/sys/dev/pci/drm/amd/display/modules/hdcp -I /usr/src/sys/dev/pci/drm/amd/display/dmub/inc -I /usr/src/sys/dev/pci/drm/i915 -D DDB -D DIAGNOSTIC -D KTRACE -D ACCOUNTING -D KMEMSTATS -D PTRACE -D POOL_DEBUG -D CRYPTO -D SYSVMSG -D SYSVSEM -D SYSVSHM -D UVM_SWAP_ENCRYPT -D FFS -D FFS2 -D FFS_SOFTUPDATES -D UFS_DIRHASH -D QUOTA -D EXT2FS -D MFS -D NFSCLIENT -D NFSSERVER -D CD9660 -D UDF -D MSDOSFS -D FIFO -D FUSE -D SOCKET_SPLICE -D TCP_ECN -D TCP_SIGNATURE -D INET6 -D IPSEC -D PPP_BSDCOMP -D PPP_DEFLATE -D PIPEX -D MROUTING -D MPLS -D BOOT_CONFIG -D USER_PCICONF -D APERTURE -D MTRR -D NTFS -D SUSPEND -D HIBERNATE -D PCIVERBOSE -D USBVERBOSE -D WSDISPLAY_COMPAT_USL -D WSDISPLAY_COMPAT_RAWKBD -D WSDISPLAY_DEFAULTSCREENS=6 -D X86EMU -D ONEWIREVERBOSE -D MULTIPROCESSOR -D MAXUSERS=80 -D _KERNEL -O2 -Wno-pointer-sign -Wno-address-of-packed-member -Wno-constant-conversion -Wno-unused-but-set-variable -Wno-gnu-folding-constant -fdebug-compilation-dir=/usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fcf-protection=branch -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -o /home/ben/Projects/scan/2024-01-11-110808-61670-1 -x c /usr/src/sys/dev/pci/drm/i915/display/dvo_ch7xxx.c
1/**************************************************************************
2
3Copyright © 2006 Dave Airlie
4
5All Rights Reserved.
6
7Permission is hereby granted, free of charge, to any person obtaining a
8copy of this software and associated documentation files (the
9"Software"), to deal in the Software without restriction, including
10without limitation the rights to use, copy, modify, merge, publish,
11distribute, sub license, and/or sell copies of the Software, and to
12permit persons to whom the Software is furnished to do so, subject to
13the following conditions:
14
15The above copyright notice and this permission notice (including the
16next paragraph) shall be included in all copies or substantial portions
17of the Software.
18
19THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
20OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
21MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
22IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
23ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
24TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
25SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
26
27**************************************************************************/
28
29#include "intel_display_types.h"
30#include "intel_dvo_dev.h"
31
32#define CH7xxx_REG_VID0x4a 0x4a
33#define CH7xxx_REG_DID0x4b 0x4b
34
35#define CH7011_VID0x83 0x83 /* 7010 as well */
36#define CH7010B_VID0x05 0x05
37#define CH7009A_VID0x84 0x84
38#define CH7009B_VID0x85 0x85
39#define CH7301_VID0x95 0x95
40
41#define CH7xxx_VID0x84 0x84
42#define CH7xxx_DID0x17 0x17
43#define CH7010_DID0x16 0x16
44
45#define CH7xxx_NUM_REGS0x4c 0x4c
46
47#define CH7xxx_CM0x1c 0x1c
48#define CH7xxx_CM_XCM(1<<0) (1<<0)
49#define CH7xxx_CM_MCP(1<<2) (1<<2)
50#define CH7xxx_INPUT_CLOCK0x1d 0x1d
51#define CH7xxx_GPIO0x1e 0x1e
52#define CH7xxx_GPIO_HPIR(1<<3) (1<<3)
53#define CH7xxx_IDF0x1f 0x1f
54
55#define CH7xxx_IDF_HSP(1<<3) (1<<3)
56#define CH7xxx_IDF_VSP(1<<4) (1<<4)
57
58#define CH7xxx_CONNECTION_DETECT0x20 0x20
59#define CH7xxx_CDET_DVI(1<<5) (1<<5)
60
61#define CH7301_DAC_CNTL0x21 0x21
62#define CH7301_HOTPLUG0x23 0x23
63#define CH7xxx_TCTL0x31 0x31
64#define CH7xxx_TVCO0x32 0x32
65#define CH7xxx_TPCP0x33 0x33
66#define CH7xxx_TPD0x34 0x34
67#define CH7xxx_TPVT0x35 0x35
68#define CH7xxx_TLPF0x36 0x36
69#define CH7xxx_TCT0x37 0x37
70#define CH7301_TEST_PATTERN0x48 0x48
71
72#define CH7xxx_PM0x49 0x49
73#define CH7xxx_PM_FPD(1<<0) (1<<0)
74#define CH7301_PM_DACPD0(1<<1) (1<<1)
75#define CH7301_PM_DACPD1(1<<2) (1<<2)
76#define CH7301_PM_DACPD2(1<<3) (1<<3)
77#define CH7xxx_PM_DVIL(1<<6) (1<<6)
78#define CH7xxx_PM_DVIP(1<<7) (1<<7)
79
80#define CH7301_SYNC_POLARITY0x56 0x56
81#define CH7301_SYNC_RGB_YUV(1<<0) (1<<0)
82#define CH7301_SYNC_POL_DVI(1<<5) (1<<5)
83
84/** @file
85 * driver for the Chrontel 7xxx DVI chip over DVO.
86 */
87
88static struct ch7xxx_id_struct {
89 u8 vid;
90 char *name;
91} ch7xxx_ids[] = {
92 { CH7011_VID0x83, "CH7011" },
93 { CH7010B_VID0x05, "CH7010B" },
94 { CH7009A_VID0x84, "CH7009A" },
95 { CH7009B_VID0x85, "CH7009B" },
96 { CH7301_VID0x95, "CH7301" },
97};
98
99static struct ch7xxx_did_struct {
100 u8 did;
101 char *name;
102} ch7xxx_dids[] = {
103 { CH7xxx_DID0x17, "CH7XXX" },
104 { CH7010_DID0x16, "CH7010B" },
105};
106
107struct ch7xxx_priv {
108 bool_Bool quiet;
109};
110
111static char *ch7xxx_get_id(u8 vid)
112{
113 int i;
114
115 for (i = 0; i < ARRAY_SIZE(ch7xxx_ids)(sizeof((ch7xxx_ids)) / sizeof((ch7xxx_ids)[0])); i++) {
116 if (ch7xxx_ids[i].vid == vid)
117 return ch7xxx_ids[i].name;
118 }
119
120 return NULL((void *)0);
121}
122
123static char *ch7xxx_get_did(u8 did)
124{
125 int i;
126
127 for (i = 0; i < ARRAY_SIZE(ch7xxx_dids)(sizeof((ch7xxx_dids)) / sizeof((ch7xxx_dids)[0])); i++) {
128 if (ch7xxx_dids[i].did == did)
129 return ch7xxx_dids[i].name;
130 }
131
132 return NULL((void *)0);
133}
134
135/** Reads an 8 bit register */
136static bool_Bool ch7xxx_readb(struct intel_dvo_device *dvo, int addr, u8 *ch)
137{
138 struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
139 struct i2c_adapter *adapter = dvo->i2c_bus;
140 u8 out_buf[2];
141 u8 in_buf[2];
142
143 struct i2c_msg msgs[] = {
144 {
145 .addr = dvo->slave_addr,
146 .flags = 0,
147 .len = 1,
148 .buf = out_buf,
149 },
150 {
151 .addr = dvo->slave_addr,
152 .flags = I2C_M_RD0x0001,
153 .len = 1,
154 .buf = in_buf,
155 }
156 };
157
158 out_buf[0] = addr;
159 out_buf[1] = 0;
160
161 if (i2c_transfer(adapter, msgs, 2) == 2) {
3
←
Assuming the condition is false
→
4
←
Taking false branch
→
162 *ch = in_buf[0];
163 return true1;
164 }
165
166 if (!ch7xxx->quiet) {
5
←
Assuming field 'quiet' is true
→
6
←
Taking false branch
→
167 DRM_DEBUG_KMS("Unable to read register 0x%02x from %s:%02x.\n",___drm_dbg(((void *)0), DRM_UT_KMS, "Unable to read register 0x%02x from %s:%02x.\n"
, addr, adapter->name, dvo->slave_addr)
168 addr, adapter->name, dvo->slave_addr)___drm_dbg(((void *)0), DRM_UT_KMS, "Unable to read register 0x%02x from %s:%02x.\n"
, addr, adapter->name, dvo->slave_addr);
169 }
170 return false0;
7
←
Returning without writing to '*ch'
→
171}
172
173/** Writes an 8 bit register */
174static bool_Bool ch7xxx_writeb(struct intel_dvo_device *dvo, int addr, u8 ch)
175{
176 struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
177 struct i2c_adapter *adapter = dvo->i2c_bus;
178 u8 out_buf[2];
179 struct i2c_msg msg = {
180 .addr = dvo->slave_addr,
181 .flags = 0,
182 .len = 2,
183 .buf = out_buf,
184 };
185
186 out_buf[0] = addr;
187 out_buf[1] = ch;
188
189 if (i2c_transfer(adapter, &msg, 1) == 1)
190 return true1;
191
192 if (!ch7xxx->quiet) {
193 DRM_DEBUG_KMS("Unable to write register 0x%02x to %s:%d.\n",___drm_dbg(((void *)0), DRM_UT_KMS, "Unable to write register 0x%02x to %s:%d.\n"
, addr, adapter->name, dvo->slave_addr)
194 addr, adapter->name, dvo->slave_addr)___drm_dbg(((void *)0), DRM_UT_KMS, "Unable to write register 0x%02x to %s:%d.\n"
, addr, adapter->name, dvo->slave_addr);
195 }
196
197 return false0;
198}
199
200static bool_Bool ch7xxx_init(struct intel_dvo_device *dvo,
201 struct i2c_adapter *adapter)
202{
203 /* this will detect the CH7xxx chip on the specified i2c bus */
204 struct ch7xxx_priv *ch7xxx;
205 u8 vendor, device;
206 char *name, *devid;
207
208 ch7xxx = kzalloc(sizeof(struct ch7xxx_priv), GFP_KERNEL(0x0001 | 0x0004));
209 if (ch7xxx == NULL((void *)0))
210 return false0;
211
212 dvo->i2c_bus = adapter;
213 dvo->dev_priv = ch7xxx;
214 ch7xxx->quiet = true1;
215
216 if (!ch7xxx_readb(dvo, CH7xxx_REG_VID0x4a, &vendor))
217 goto out;
218
219 name = ch7xxx_get_id(vendor);
220 if (!name) {
221 DRM_DEBUG_KMS("ch7xxx not detected; got VID 0x%02x from %s slave %d.\n",___drm_dbg(((void *)0), DRM_UT_KMS, "ch7xxx not detected; got VID 0x%02x from %s slave %d.\n"
, vendor, adapter->name, dvo->slave_addr)
222 vendor, adapter->name, dvo->slave_addr)___drm_dbg(((void *)0), DRM_UT_KMS, "ch7xxx not detected; got VID 0x%02x from %s slave %d.\n"
, vendor, adapter->name, dvo->slave_addr);
223 goto out;
224 }
225
226
227 if (!ch7xxx_readb(dvo, CH7xxx_REG_DID0x4b, &device))
228 goto out;
229
230 devid = ch7xxx_get_did(device);
231 if (!devid) {
232 DRM_DEBUG_KMS("ch7xxx not detected; got DID 0x%02x from %s slave %d.\n",___drm_dbg(((void *)0), DRM_UT_KMS, "ch7xxx not detected; got DID 0x%02x from %s slave %d.\n"
, device, adapter->name, dvo->slave_addr)
233 device, adapter->name, dvo->slave_addr)___drm_dbg(((void *)0), DRM_UT_KMS, "ch7xxx not detected; got DID 0x%02x from %s slave %d.\n"
, device, adapter->name, dvo->slave_addr);
234 goto out;
235 }
236
237 ch7xxx->quiet = false0;
238 DRM_DEBUG_KMS("Detected %s chipset, vendor/device ID 0x%02x/0x%02x\n",___drm_dbg(((void *)0), DRM_UT_KMS, "Detected %s chipset, vendor/device ID 0x%02x/0x%02x\n"
, name, vendor, device)
239 name, vendor, device)___drm_dbg(((void *)0), DRM_UT_KMS, "Detected %s chipset, vendor/device ID 0x%02x/0x%02x\n"
, name, vendor, device);
240 return true1;
241out:
242 kfree(ch7xxx);
243 return false0;
244}
245
246static enum drm_connector_status ch7xxx_detect(struct intel_dvo_device *dvo)
247{
248 u8 cdet, orig_pm, pm;
1
'cdet' declared without an initial value
→
249
250 ch7xxx_readb(dvo, CH7xxx_PM0x49, &orig_pm);
251
252 pm = orig_pm;
253 pm &= ~CH7xxx_PM_FPD(1<<0);
254 pm |= CH7xxx_PM_DVIL(1<<6) | CH7xxx_PM_DVIP(1<<7);
255
256 ch7xxx_writeb(dvo, CH7xxx_PM0x49, pm);
257
258 ch7xxx_readb(dvo, CH7xxx_CONNECTION_DETECT0x20, &cdet);
2
←
Calling 'ch7xxx_readb'
→
8
←
Returning from 'ch7xxx_readb'
→
259
260 ch7xxx_writeb(dvo, CH7xxx_PM0x49, orig_pm);
261
262 if (cdet & CH7xxx_CDET_DVI(1<<5))
9
←
The left operand of '&' is a garbage value
263 return connector_status_connected;
264 return connector_status_disconnected;
265}
266
267static enum drm_mode_status ch7xxx_mode_valid(struct intel_dvo_device *dvo,
268 struct drm_display_mode *mode)
269{
270 if (mode->clock > 165000)
271 return MODE_CLOCK_HIGH;
272
273 return MODE_OK;
274}
275
276static void ch7xxx_mode_set(struct intel_dvo_device *dvo,
277 const struct drm_display_mode *mode,
278 const struct drm_display_mode *adjusted_mode)
279{
280 u8 tvco, tpcp, tpd, tlpf, idf;
281
282 if (mode->clock <= 65000) {
283 tvco = 0x23;
284 tpcp = 0x08;
285 tpd = 0x16;
286 tlpf = 0x60;
287 } else {
288 tvco = 0x2d;
289 tpcp = 0x06;
290 tpd = 0x26;
291 tlpf = 0xa0;
292 }
293
294 ch7xxx_writeb(dvo, CH7xxx_TCTL0x31, 0x00);
295 ch7xxx_writeb(dvo, CH7xxx_TVCO0x32, tvco);
296 ch7xxx_writeb(dvo, CH7xxx_TPCP0x33, tpcp);
297 ch7xxx_writeb(dvo, CH7xxx_TPD0x34, tpd);
298 ch7xxx_writeb(dvo, CH7xxx_TPVT0x35, 0x30);
299 ch7xxx_writeb(dvo, CH7xxx_TLPF0x36, tlpf);
300 ch7xxx_writeb(dvo, CH7xxx_TCT0x37, 0x00);
301
302 ch7xxx_readb(dvo, CH7xxx_IDF0x1f, &idf);
303
304 idf &= ~(CH7xxx_IDF_HSP(1<<3) | CH7xxx_IDF_VSP(1<<4));
305 if (mode->flags & DRM_MODE_FLAG_PHSYNC(1<<0))
306 idf |= CH7xxx_IDF_HSP(1<<3);
307
308 if (mode->flags & DRM_MODE_FLAG_PVSYNC(1<<2))
309 idf |= CH7xxx_IDF_VSP(1<<4);
310
311 ch7xxx_writeb(dvo, CH7xxx_IDF0x1f, idf);
312}
313
314/* set the CH7xxx power state */
315static void ch7xxx_dpms(struct intel_dvo_device *dvo, bool_Bool enable)
316{
317 if (enable)
318 ch7xxx_writeb(dvo, CH7xxx_PM0x49, CH7xxx_PM_DVIL(1<<6) | CH7xxx_PM_DVIP(1<<7));
319 else
320 ch7xxx_writeb(dvo, CH7xxx_PM0x49, CH7xxx_PM_FPD(1<<0));
321}
322
323static bool_Bool ch7xxx_get_hw_state(struct intel_dvo_device *dvo)
324{
325 u8 val;
326
327 ch7xxx_readb(dvo, CH7xxx_PM0x49, &val);
328
329 if (val & (CH7xxx_PM_DVIL(1<<6) | CH7xxx_PM_DVIP(1<<7)))
330 return true1;
331 else
332 return false0;
333}
334
335static void ch7xxx_dump_regs(struct intel_dvo_device *dvo)
336{
337 int i;
338
339 for (i = 0; i < CH7xxx_NUM_REGS0x4c; i++) {
340 u8 val;
341 if ((i % 8) == 0)
342 DRM_DEBUG_KMS("\n %02X: ", i)___drm_dbg(((void *)0), DRM_UT_KMS, "\n %02X: ", i);
343 ch7xxx_readb(dvo, i, &val);
344 DRM_DEBUG_KMS("%02X ", val)___drm_dbg(((void *)0), DRM_UT_KMS, "%02X ", val);
345 }
346}
347
348static void ch7xxx_destroy(struct intel_dvo_device *dvo)
349{
350 struct ch7xxx_priv *ch7xxx = dvo->dev_priv;
351
352 if (ch7xxx) {
353 kfree(ch7xxx);
354 dvo->dev_priv = NULL((void *)0);
355 }
356}
357
358const struct intel_dvo_dev_ops ch7xxx_ops = {
359 .init = ch7xxx_init,
360 .detect = ch7xxx_detect,
361 .mode_valid = ch7xxx_mode_valid,
362 .mode_set = ch7xxx_mode_set,
363 .dpms = ch7xxx_dpms,
364 .get_hw_state = ch7xxx_get_hw_state,
365 .dump_regs = ch7xxx_dump_regs,
366 .destroy = ch7xxx_destroy,
367};