Bug Summary

File:dev/pci/drm/amd/display/dc/link/link_hwss_dio.c
Warning:line 64, column 4
Access to field 'id' results in a dereference of a null pointer (loaded from field 'stream_enc')

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.4 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name link_hwss_dio.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model static -mframe-pointer=all -relaxed-aliasing -ffp-contract=on -fno-rounding-math -mconstructor-aliases -ffreestanding -mcmodel=kernel -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -target-feature -sse2 -target-feature -sse -target-feature -3dnow -target-feature -mmx -target-feature +save-args -target-feature +retpoline-external-thunk -disable-red-zone -no-implicit-float -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -nostdsysteminc -nobuiltininc -resource-dir /usr/local/llvm16/lib/clang/16 -I /usr/src/sys -I /usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -I /usr/src/sys/arch -I /usr/src/sys/dev/pci/drm/include -I /usr/src/sys/dev/pci/drm/include/uapi -I /usr/src/sys/dev/pci/drm/amd/include/asic_reg -I /usr/src/sys/dev/pci/drm/amd/include -I /usr/src/sys/dev/pci/drm/amd/amdgpu -I /usr/src/sys/dev/pci/drm/amd/display -I /usr/src/sys/dev/pci/drm/amd/display/include -I /usr/src/sys/dev/pci/drm/amd/display/dc -I /usr/src/sys/dev/pci/drm/amd/display/amdgpu_dm -I /usr/src/sys/dev/pci/drm/amd/pm/inc -I /usr/src/sys/dev/pci/drm/amd/pm/legacy-dpm -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu11 -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu12 -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/smu13 -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/inc -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/hwmgr -I /usr/src/sys/dev/pci/drm/amd/pm/powerplay/smumgr -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc -I /usr/src/sys/dev/pci/drm/amd/pm/swsmu/inc/pmfw_if -I /usr/src/sys/dev/pci/drm/amd/display/dc/inc -I /usr/src/sys/dev/pci/drm/amd/display/dc/inc/hw -I /usr/src/sys/dev/pci/drm/amd/display/dc/clk_mgr -I /usr/src/sys/dev/pci/drm/amd/display/modules/inc -I /usr/src/sys/dev/pci/drm/amd/display/modules/hdcp -I /usr/src/sys/dev/pci/drm/amd/display/dmub/inc -I /usr/src/sys/dev/pci/drm/i915 -D DDB -D DIAGNOSTIC -D KTRACE -D ACCOUNTING -D KMEMSTATS -D PTRACE -D POOL_DEBUG -D CRYPTO -D SYSVMSG -D SYSVSEM -D SYSVSHM -D UVM_SWAP_ENCRYPT -D FFS -D FFS2 -D FFS_SOFTUPDATES -D UFS_DIRHASH -D QUOTA -D EXT2FS -D MFS -D NFSCLIENT -D NFSSERVER -D CD9660 -D UDF -D MSDOSFS -D FIFO -D FUSE -D SOCKET_SPLICE -D TCP_ECN -D TCP_SIGNATURE -D INET6 -D IPSEC -D PPP_BSDCOMP -D PPP_DEFLATE -D PIPEX -D MROUTING -D MPLS -D BOOT_CONFIG -D USER_PCICONF -D APERTURE -D MTRR -D NTFS -D SUSPEND -D HIBERNATE -D PCIVERBOSE -D USBVERBOSE -D WSDISPLAY_COMPAT_USL -D WSDISPLAY_COMPAT_RAWKBD -D WSDISPLAY_DEFAULTSCREENS=6 -D X86EMU -D ONEWIREVERBOSE -D MULTIPROCESSOR -D MAXUSERS=80 -D _KERNEL -O2 -Wno-pointer-sign -Wno-address-of-packed-member -Wno-constant-conversion -Wno-unused-but-set-variable -Wno-gnu-folding-constant -fdebug-compilation-dir=/usr/src/sys/arch/amd64/compile/GENERIC.MP/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fcf-protection=branch -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -o /home/ben/Projects/scan/2024-01-11-110808-61670-1 -x c /usr/src/sys/dev/pci/drm/amd/display/dc/link/link_hwss_dio.c
1/*
2 * Copyright 2022 Advanced Micro Devices, Inc.
3 *
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
10 *
11 * The above copyright notice and this permission notice shall be included in
12 * all copies or substantial portions of the Software.
13 *
14 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
15 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
16 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
17 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
18 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
19 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
20 * OTHER DEALINGS IN THE SOFTWARE.
21 *
22 * Authors: AMD
23 *
24 */
25#include "link_hwss_dio.h"
26#include "core_types.h"
27#include "dc_link_dp.h"
28#include "link_enc_cfg.h"
29
30void set_dio_throttled_vcp_size(struct pipe_ctx *pipe_ctx,
31 struct fixed31_32 throttled_vcp_size)
32{
33 struct stream_encoder *stream_encoder = pipe_ctx->stream_res.stream_enc;
34
35 stream_encoder->funcs->set_throttled_vcp_size(
36 stream_encoder,
37 throttled_vcp_size);
38}
39
40void setup_dio_stream_encoder(struct pipe_ctx *pipe_ctx)
41{
42 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(pipe_ctx->stream->link);
43 struct stream_encoder *stream_enc = pipe_ctx->stream_res.stream_enc;
44
45 link_enc->funcs->connect_dig_be_to_fe(link_enc,
46 pipe_ctx->stream_res.stream_enc->id, true1);
47 if (dc_is_dp_signal(pipe_ctx->stream->signal))
48 dp_source_sequence_trace(pipe_ctx->stream->link,
49 DPCD_SOURCE_SEQ_AFTER_CONNECT_DIG_FE_BE);
50 if (stream_enc->funcs->enable_fifo)
51 stream_enc->funcs->enable_fifo(stream_enc);
52}
53
54void reset_dio_stream_encoder(struct pipe_ctx *pipe_ctx)
55{
56 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(pipe_ctx->stream->link);
57 struct stream_encoder *stream_enc = pipe_ctx->stream_res.stream_enc;
58
59 if (stream_enc && stream_enc->funcs->disable_fifo)
1
Assuming 'stream_enc' is null
→
60 stream_enc->funcs->disable_fifo(stream_enc);
61
62 link_enc->funcs->connect_dig_be_to_fe(
63 link_enc,
64 pipe_ctx->stream_res.stream_enc->id,
2
←
Access to field 'id' results in a dereference of a null pointer (loaded from field 'stream_enc')
65 false0);
66 if (dc_is_dp_signal(pipe_ctx->stream->signal))
67 dp_source_sequence_trace(pipe_ctx->stream->link,
68 DPCD_SOURCE_SEQ_AFTER_DISCONNECT_DIG_FE_BE);
69
70}
71
72void setup_dio_stream_attribute(struct pipe_ctx *pipe_ctx)
73{
74 struct stream_encoder *stream_encoder = pipe_ctx->stream_res.stream_enc;
75 struct dc_stream_state *stream = pipe_ctx->stream;
76 struct dc_link *link = stream->link;
77
78 if (!dc_is_virtual_signal(stream->signal))
79 stream_encoder->funcs->setup_stereo_sync(
80 stream_encoder,
81 pipe_ctx->stream_res.tg->inst,
82 stream->timing.timing_3d_format != TIMING_3D_FORMAT_NONE);
83
84 if (dc_is_dp_signal(stream->signal))
85 stream_encoder->funcs->dp_set_stream_attribute(
86 stream_encoder,
87 &stream->timing,
88 stream->output_color_space,
89 stream->use_vsc_sdp_for_colorimetry,
90 link->dpcd_caps.dprx_feature.bits.SST_SPLIT_SDP_CAP);
91 else if (dc_is_hdmi_tmds_signal(stream->signal))
92 stream_encoder->funcs->hdmi_set_stream_attribute(
93 stream_encoder,
94 &stream->timing,
95 stream->phy_pix_clk,
96 pipe_ctx->stream_res.audio != NULL((void *)0));
97 else if (dc_is_dvi_signal(stream->signal))
98 stream_encoder->funcs->dvi_set_stream_attribute(
99 stream_encoder,
100 &stream->timing,
101 (stream->signal == SIGNAL_TYPE_DVI_DUAL_LINK) ?
102 true1 : false0);
103 else if (dc_is_lvds_signal(stream->signal))
104 stream_encoder->funcs->lvds_set_stream_attribute(
105 stream_encoder,
106 &stream->timing);
107
108 if (dc_is_dp_signal(stream->signal))
109 dp_source_sequence_trace(link, DPCD_SOURCE_SEQ_AFTER_DP_STREAM_ATTR);
110}
111
112void enable_dio_dp_link_output(struct dc_link *link,
113 const struct link_resource *link_res,
114 enum amd_signal_type signal,
115 enum clock_source_id clock_source,
116 const struct dc_link_settings *link_settings)
117{
118 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(link);
119
120 if (dc_is_dp_sst_signal(signal))
121 link_enc->funcs->enable_dp_output(
122 link_enc,
123 link_settings,
124 clock_source);
125 else
126 link_enc->funcs->enable_dp_mst_output(
127 link_enc,
128 link_settings,
129 clock_source);
130 dp_source_sequence_trace(link, DPCD_SOURCE_SEQ_AFTER_ENABLE_LINK_PHY);
131}
132
133void disable_dio_link_output(struct dc_link *link,
134 const struct link_resource *link_res,
135 enum amd_signal_type signal)
136{
137 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(link);
138
139 link_enc->funcs->disable_output(link_enc, signal);
140 dp_source_sequence_trace(link, DPCD_SOURCE_SEQ_AFTER_DISABLE_LINK_PHY);
141}
142
143void set_dio_dp_link_test_pattern(struct dc_link *link,
144 const struct link_resource *link_res,
145 struct encoder_set_dp_phy_pattern_param *tp_params)
146{
147 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(link);
148
149 link_enc->funcs->dp_set_phy_pattern(link_enc, tp_params);
150 dp_source_sequence_trace(link, DPCD_SOURCE_SEQ_AFTER_SET_SOURCE_PATTERN);
151}
152
153void set_dio_dp_lane_settings(struct dc_link *link,
154 const struct link_resource *link_res,
155 const struct dc_link_settings *link_settings,
156 const struct dc_lane_settings lane_settings[LANE_COUNT_DP_MAX])
157{
158 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(link);
159
160 link_enc->funcs->dp_set_lane_settings(link_enc, link_settings, lane_settings);
161}
162
163static void update_dio_stream_allocation_table(struct dc_link *link,
164 const struct link_resource *link_res,
165 const struct link_mst_stream_allocation_table *table)
166{
167 struct link_encoder *link_enc = link_enc_cfg_get_link_enc(link);
168
169 ASSERT(link_enc)do { if (({ static int __warned; int __ret = !!(!(link_enc));
if (__ret && !__warned) { printf("WARNING %s failed at %s:%d\n"
, "!(link_enc)", "/usr/src/sys/dev/pci/drm/amd/display/dc/link/link_hwss_dio.c"
, 169); __warned = 1; } __builtin_expect(!!(__ret), 0); })) do
{} while (0); } while (0);
170 link_enc->funcs->update_mst_stream_allocation_table(link_enc, table);
171}
172
173static const struct link_hwss dio_link_hwss = {
174 .setup_stream_encoder = setup_dio_stream_encoder,
175 .reset_stream_encoder = reset_dio_stream_encoder,
176 .setup_stream_attribute = setup_dio_stream_attribute,
177 .disable_link_output = disable_dio_link_output,
178 .ext = {
179 .set_throttled_vcp_size = set_dio_throttled_vcp_size,
180 .enable_dp_link_output = enable_dio_dp_link_output,
181 .set_dp_link_test_pattern = set_dio_dp_link_test_pattern,
182 .set_dp_lane_settings = set_dio_dp_lane_settings,
183 .update_stream_allocation_table = update_dio_stream_allocation_table,
184 },
185};
186
187bool_Bool can_use_dio_link_hwss(const struct dc_link *link,
188 const struct link_resource *link_res)
189{
190 return link->link_enc != NULL((void *)0);
191}
192
193const struct link_hwss *get_dio_link_hwss(void)
194{
195 return &dio_link_hwss;
196}