/usr/src/usr.sbin/acme-client/main.c

Bug Summary

File:	src/usr.sbin/acme-client/main.c
Warning:	line 378, column 2 Potential leak of memory pointed to by 'conffile'

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name main.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.sbin/acme-client/obj -resource-dir /usr/local/lib/clang/13.0.0 -I /usr/src/usr.sbin/acme-client -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.sbin/acme-client/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/usr.sbin/acme-client/main.c

1/*	$Id: main.c,v 1.54 2020/05/10 12:06:18 benno Exp $ */
2/*
* Copyright (c) 2016 Kristaps Dzonsons <kristaps@bsd.lv>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHORS DISCLAIM ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/

18#include <sys/socket.h>

20#include <ctype.h>
21#include <err.h>
22#include <libgen.h>
23#include <stdarg.h>
24#include <stdio.h>
25#include <stdlib.h>
26#include <string.h>
27#include <unistd.h>

29#include "extern.h"
30#include "parse.h"

32#define WWW_DIR"/var/www/acme" "/var/www/acme"
33#define CONF_FILE"/etc/acme-client.conf" "/etc/acme-client.conf"

35int		 verbose;
36enum comp 	 proccomp;

38int
39main(int argc, char *argv[])
40{
const char	 **alts = NULL((void *)0);
char		 *certdir = NULL((void *)0);
char		 *chngdir = NULL((void *)0), *auth = NULL((void *)0);
char		 *conffile = CONF_FILE"/etc/acme-client.conf";
char		 *tmps, *tmpsd;
int		  key_fds[2], acct_fds[2], chng_fds[2], cert_fds[2];
int		  file_fds[2], dns_fds[2], rvk_fds[2];
int		  force = 0;
int		  c, rc, revocate = 0;
int		  popts = 0;
pid_t		  pids[COMP__MAX];
size_t		  i, altsz, ne;

struct acme_conf	*conf = NULL((void *)0);
struct authority_c	*authority = NULL((void *)0);
struct domain_c		*domain = NULL((void *)0);
struct altname_c	*ac;

while ((c = getopt(argc, argv, "Fnrvf:")) != -1)
1
Assuming the condition is true→
2
←
Loop condition is true.  Entering loop body→
8
←
Assuming the condition is true→
9
←
Loop condition is true.  Entering loop body→
switch (c) {
3
←
Control jumps to 'case 102:'  at line 64→
10
←
Control jumps to the 'default' case at line 78→
case 'F':
	force = 1;
	break;
case 'f':
	if ((conffile = strdup(optarg)) == NULL((void *)0))
4
←
Memory is allocated→
5
←
Assuming the condition is false→
6
←
Taking false branch→
		err(EXIT_FAILURE1, "strdup");
	break;
7
←
 Execution continues on line 59→
case 'n':
	popts |= ACME_OPT_CHECK0x00000004;
	break;
case 'r':
	revocate = 1;
	break;
case 'v':
	verbose = verbose ? 2 : 1;
	popts |= ACME_OPT_VERBOSE0x00000001;
	break;
default:
	goto usage;
11
←
Control jumps to line 378→
}

if (getuid() != 0)
errx(EXIT_FAILURE1, "must be run as root");

/* parse config file */
if ((conf = parse_config(conffile, popts)) == NULL((void *)0))
return EXIT_FAILURE1;

argc -= optind;
argv += optind;
if (argc != 1)
goto usage;

if ((domain = domain_find_handle(conf, argv[0])) == NULL((void *)0))
errx(EXIT_FAILURE1, "domain %s not found", argv[0]);

argc--;
argv++;

/*
* The parser enforces that at least cert or fullchain is set.
* XXX Test if cert, chain and fullchain have the same dirname?
*/
tmps = domain->cert ? domain->cert : domain->fullchain;
if ((tmps = strdup(tmps)) == NULL((void *)0))
err(EXIT_FAILURE1, "strdup");
if ((tmpsd = dirname(tmps)) == NULL((void *)0))
err(EXIT_FAILURE1, "dirname");
if ((certdir = strdup(tmpsd)) == NULL((void *)0))
err(EXIT_FAILURE1, "strdup");	
free(tmps);
tmps = tmpsd = NULL((void *)0);


/* chain or fullchain can be relative paths according */
if (domain->chain && domain->chain[0] != '/') {
if (asprintf(&tmps, "%s/%s", certdir, domain->chain) == -1)
	err(EXIT_FAILURE1, "asprintf");
free(domain->chain);
domain->chain = tmps;
tmps = NULL((void *)0);
}
if (domain->fullchain && domain->fullchain[0] != '/') {
if (asprintf(&tmps, "%s/%s", certdir, domain->fullchain) == -1)
	err(EXIT_FAILURE1, "asprintf");
free(domain->fullchain);
domain->fullchain = tmps;
tmps = NULL((void *)0);
}

if ((auth = domain->auth) == NULL((void *)0)) {
/* use the first authority from the config as default XXX */
authority = authority_find0(conf);
if (authority == NULL((void *)0))
	errx(EXIT_FAILURE1, "no authorities configured");
} else {
authority = authority_find(conf, auth);
if (authority == NULL((void *)0))
	errx(EXIT_FAILURE1, "authority %s not found", auth);
}

if ((chngdir = domain->challengedir) == NULL((void *)0))
if ((chngdir = strdup(WWW_DIR"/var/www/acme")) == NULL((void *)0))
	err(EXIT_FAILURE1, "strdup");

/*
* Do some quick checks to see if our paths exist.
* This will be done in the children, but we might as well check
* now before the fork.
* XXX maybe use conf_check_file() from parse.y
*/

ne = 0;

if (access(certdir, R_OK0x04) == -1) {
warnx("%s: cert directory must exist", certdir);
ne++;
}

if (access(chngdir, R_OK0x04) == -1) {
warnx("%s: challenge directory must exist", chngdir);
ne++;
}

if (ne > 0)
return EXIT_FAILURE1;

if (popts & ACME_OPT_CHECK0x00000004)
return EXIT_SUCCESS0;

/* Set the zeroth altname as our domain. */
altsz = domain->altname_count + 1;
alts = calloc(altsz, sizeof(char *));
if (alts == NULL((void *)0))
err(EXIT_FAILURE1, "calloc");
alts[0] = domain->domain;
i = 1;
/* XXX get rid of alts[] later */
TAILQ_FOREACH(ac, &domain->altname_list, entry)for((ac) = ((&domain->altname_list)->tqh_first); (ac
) != ((void *)0); (ac) = ((ac)->entry.tqe_next))
alts[i++] = ac->domain;

/*
* Open channels between our components.
*/

if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, key_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, acct_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, chng_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, cert_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, file_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, dns_fds) == -1)
err(EXIT_FAILURE1, "socketpair");
if (socketpair(AF_UNIX1, SOCK_STREAM1, 0, rvk_fds) == -1)
err(EXIT_FAILURE1, "socketpair");

/* Start with the network-touching process. */

if ((pids[COMP_NET] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_NET] == 0) {
proccomp = COMP_NET;
close(key_fds[0]);
close(acct_fds[0]);
close(chng_fds[0]);
close(cert_fds[0]);
close(file_fds[0]);
close(file_fds[1]);
close(dns_fds[0]);
close(rvk_fds[0]);
c = netproc(key_fds[1], acct_fds[1],
    chng_fds[1], cert_fds[1],
    dns_fds[1], rvk_fds[1],
    revocate, authority,
    (const char *const *)alts, altsz);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(key_fds[1]);
close(acct_fds[1]);
close(chng_fds[1]);
close(cert_fds[1]);
close(dns_fds[1]);
close(rvk_fds[1]);

/* Now the key-touching component. */

if ((pids[COMP_KEY] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_KEY] == 0) {
proccomp = COMP_KEY;
close(cert_fds[0]);
close(dns_fds[0]);
close(rvk_fds[0]);
close(acct_fds[0]);
close(chng_fds[0]);
close(file_fds[0]);
close(file_fds[1]);
c = keyproc(key_fds[0], domain->key,
    (const char **)alts, altsz,
    domain->keytype);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(key_fds[0]);

/* The account-touching component. */

if ((pids[COMP_ACCOUNT] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_ACCOUNT] == 0) {
proccomp = COMP_ACCOUNT;
close(cert_fds[0]);
close(dns_fds[0]);
close(rvk_fds[0]);
close(chng_fds[0]);
close(file_fds[0]);
close(file_fds[1]);
c = acctproc(acct_fds[0], authority->account,
    authority->keytype);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(acct_fds[0]);

/* The challenge-accepting component. */

if ((pids[COMP_CHALLENGE] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_CHALLENGE] == 0) {
proccomp = COMP_CHALLENGE;
close(cert_fds[0]);
close(dns_fds[0]);
close(rvk_fds[0]);
close(file_fds[0]);
close(file_fds[1]);
c = chngproc(chng_fds[0], chngdir);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(chng_fds[0]);

/* The certificate-handling component. */

if ((pids[COMP_CERT] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_CERT] == 0) {
proccomp = COMP_CERT;
close(dns_fds[0]);
close(rvk_fds[0]);
close(file_fds[1]);
c = certproc(cert_fds[0], file_fds[0]);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(cert_fds[0]);
close(file_fds[0]);

/* The certificate-handling component. */

if ((pids[COMP_FILE] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_FILE] == 0) {
proccomp = COMP_FILE;
close(dns_fds[0]);
close(rvk_fds[0]);
c = fileproc(file_fds[1], certdir, domain->cert, domain->chain,
    domain->fullchain);
/*
 * This is different from the other processes in that it
 * can return 2 if the certificates were updated.
 */
exit(c > 1 ? 2 : (c ? EXIT_SUCCESS0 : EXIT_FAILURE1));
}

close(file_fds[1]);

/* The DNS lookup component. */

if ((pids[COMP_DNS] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_DNS] == 0) {
proccomp = COMP_DNS;
close(rvk_fds[0]);
c = dnsproc(dns_fds[0]);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(dns_fds[0]);

/* The expiration component. */

if ((pids[COMP_REVOKE] = fork()) == -1)
err(EXIT_FAILURE1, "fork");

if (pids[COMP_REVOKE] == 0) {
proccomp = COMP_REVOKE;
c = revokeproc(rvk_fds[0], domain->cert != NULL((void *)0) ? domain->cert :
    domain->fullchain, force, revocate,
    (const char *const *)alts, altsz);
exit(c ? EXIT_SUCCESS0 : EXIT_FAILURE1);
}

close(rvk_fds[0]);

/* Jail: sandbox, file-system, user. */

if (pledge("stdio", NULL((void *)0)) == -1)
err(EXIT_FAILURE1, "pledge");

/*
* Collect our subprocesses.
* Require that they both have exited cleanly.
*/

rc = checkexit(pids[COMP_KEY], COMP_KEY) +
   checkexit(pids[COMP_CERT], COMP_CERT) +
   checkexit(pids[COMP_NET], COMP_NET) +
   checkexit_ext(&c, pids[COMP_FILE], COMP_FILE) +
   checkexit(pids[COMP_ACCOUNT], COMP_ACCOUNT) +
   checkexit(pids[COMP_CHALLENGE], COMP_CHALLENGE) +
   checkexit(pids[COMP_DNS], COMP_DNS) +
   checkexit(pids[COMP_REVOKE], COMP_REVOKE);

return rc != COMP__MAX ? EXIT_FAILURE1 : (c == 2 ? EXIT_SUCCESS0 : 2);
377usage:
fprintf(stderr(&__sF[2]),
12
←
Potential leak of memory pointed to by 'conffile'
   "usage: acme-client [-Fnrv] [-f configfile] handle\n");
return EXIT_FAILURE1;
381}