/usr/src/games/sail/dr_3.c

Bug Summary

File:	src/games/sail/dr_3.c
Warning:	line 245, column 7 Branch condition evaluates to a garbage value

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name dr_3.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/games/sail/obj -resource-dir /usr/local/lib/clang/13.0.0 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/games/sail/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/games/sail/dr_3.c

1/*	$OpenBSD: dr_3.c,v 1.7 2016/01/08 20:26:33 mestre Exp $	*/
2/*	$NetBSD: dr_3.c,v 1.3 1995/04/22 10:36:49 cgd Exp $	*/

4/*
* Copyright (c) 1983, 1993
*	The Regents of the University of California.  All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
*    notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
*    notice, this list of conditions and the following disclaimer in the
*    documentation and/or other materials provided with the distribution.
* 3. Neither the name of the University nor the names of its contributors
*    may be used to endorse or promote products derived from this software
*    without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/

33#include <stdlib.h>
34#include <string.h>

36#include "driver.h"
37#include "extern.h"
38#include "player.h"

40/* move all comp ships */
41void
42moveall(void)
43{
struct ship *sp, *sq;		/* r11, r10 */
int n;				/* r9 */
int k, l;			/* r8, r7 */
int row[NSHIP10], col[NSHIP10], dir[NSHIP10], drift[NSHIP10];
char moved[NSHIP10];

/*
* first try to create moves for OUR ships
*/
foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
1
Loop condition is false. Execution continues on line 80→
struct ship *closest;
int ma, ta;
char af;

if (sp->file->captain[0] || sp->file->dir == 0)
	continue;
if (!sp->file->struck && windspeed && !snagged(sp)(((sp)->file->ngrap) + ((sp)->file->nfoul))
    && sp->specs->crew3) {
	ta = maxturns(sp, &af);
	ma = maxmove(sp, sp->file->dir, 0);
	closest = closestenemy(sp, 0, 0);
	if (closest == 0)
		*sp->file->movebuf = '\0';
	else
		closeon(sp, closest, sp->file->movebuf,
			sizeof sp->file->movebuf,
			ta, ma, af);
} else
	*sp->file->movebuf = '\0';
}
/*
* Then execute the moves for ALL ships (dead ones too),
* checking for collisions and snags at each step.
* The old positions are saved in row[], col[], dir[].
* At the end, we compare and write out the changes.
*/
n = 0;
foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
2
←
Loop condition is false. Execution continues on line 100→
if (snagged(sp)(((sp)->file->ngrap) + ((sp)->file->nfoul)))
	(void) strlcpy(sp->file->movebuf, "d",
	    sizeof sp->file->movebuf);
else
	if (*sp->file->movebuf != 'd')
		(void) strlcat(sp->file->movebuf, "d",
			sizeof sp->file->movebuf);
row[n] = sp->file->row;
col[n] = sp->file->col;
dir[n] = sp->file->dir;
drift[n] = sp->file->drift;
moved[n] = 0;
n++;
}
/*
* Now resolve collisions.
* This is the tough part.
*/
for (k = 0; stillmoving(k); k++) {
3
←
Loop condition is true.  Entering loop body→
/*
 * Step once.
 * And propagate the nulls at the end of sp->file->movebuf.
 */
n = 0;
foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
4
←
Loop condition is true.  Entering loop body→
	if (!sp->file->movebuf[k])
5
←
Assuming the condition is false→
6
←
Taking false branch→
		sp->file->movebuf[k+1] = '\0';
	else if (sp->file->dir)
7
←
Assuming field 'dir' is not equal to 0→
8
←
Taking true branch→
		step(sp->file->movebuf[k], sp, &moved[n]);
9
←
Calling 'step'→
	n++;
}
/*
 * The real stuff.
 */
n = 0;
foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
	if (sp->file->dir == 0 || is_isolated(sp))
		goto cont1;
	l = 0;
	foreachship(sq)for ((sq) = cc->ship; (sq) < ls; (sq)++) {
		char snap = 0;

		if (sp == sq)
			goto cont2;
		if (sq->file->dir == 0)
			goto cont2;
		if (!push(sp, sq))
			goto cont2;
		if (snagged2(sp, sq)(((sp)->file->grap[(sq)->file->index].sn_count) +
 ((sp)->file->foul[(sq)->file->index].sn_count)) && range(sp, sq) > 1)
			snap++;
		if (!range(sp, sq) && !fouled2(sp, sq)((sp)->file->foul[(sq)->file->index].sn_count)) {
			makesignal(sp, "collision with $$", sq);
			if (die()(arc4random_uniform(6) + 1) < 4) {
				makesignal(sp, "fouled with $$",
					sq);
				Write(W_FOUL9, sp, l, 0, 0, 0);
				Write(W_FOUL9, sq, n, 0, 0, 0);
			}
			snap++;
		}
		if (snap) {
			sp->file->movebuf[k + 1] = 0;
			sq->file->movebuf[k + 1] = 0;
			sq->file->row = sp->file->row - 1;
			if (sp->file->dir == 1
			    || sp->file->dir == 5)
				sq->file->col =
					sp->file->col - 1;
			else
				sq->file->col = sp->file->col;
			sq->file->dir = sp->file->dir;
		}
	cont2:
		l++;
	}
cont1:
	n++;
}
}
/*
* Clear old moves.  And write out new pos.
*/
n = 0;
foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
if (sp->file->dir != 0) {
	*sp->file->movebuf = 0;
	if (row[n] != sp->file->row)
		Write(W_ROW23, sp, sp->file->row, 0, 0, 0);
	if (col[n] != sp->file->col)
		Write(W_COL21, sp, sp->file->col, 0, 0, 0);
	if (dir[n] != sp->file->dir)
		Write(W_DIR22, sp, sp->file->dir, 0, 0, 0);
	if (drift[n] != sp->file->drift)
		Write(W_DRIFT6, sp, sp->file->drift, 0, 0, 0);
}
n++;
}
179}

181int
182stillmoving(int k)
183{
struct ship *sp;

foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++)
if (sp->file->movebuf[k])
	return 1;
return 0;
190}

192int
193is_isolated(struct ship *ship)
194{
struct ship *sp;

foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
if (ship != sp && range(ship, sp) <= 10)
	return 0;
}
return 1;
202}

204int
205push(struct ship *from, struct ship *to)
206{
int bs, sb;

sb = to->specs->guns;
bs = from->specs->guns;
if (sb > bs)
return 1;
if (sb < bs)
return 0;
return from < to;
216}

218void
219step(int com, struct ship *sp, char *moved)
220{
int dist;

switch (com) {
10
←
Control jumps to 'case 100:'  at line 244→
case 'r':
if (++sp->file->dir == 9)
	sp->file->dir = 1;
break;
case 'l':
if (--sp->file->dir == 0)
	sp->file->dir = 8;
break;
case '0': case '1': case '2': case '3':
case '4': case '5': case '6': case '7':
if (sp->file->dir % 2 == 0)
	dist = dtab[com - '0'];
else
	dist = com - '0';
sp->file->row -= dr[sp->file->dir] * dist;
sp->file->col -= dc[sp->file->dir] * dist;
*moved = 1;
break;
case 'b':
break;
case 'd':
if (!*moved) {
11
←
Branch condition evaluates to a garbage value
	if (windspeed != 0 && ++sp->file->drift > 2 &&
	    ((sp->specs->class >= 3 && !snagged(sp)(((sp)->file->ngrap) + ((sp)->file->nfoul)))
	     || (turn & 1) == 0)) {
		sp->file->row -= dr[winddir];
		sp->file->col -= dc[winddir];
	}
} else
	sp->file->drift = 0;
break;
}
256}

258void
259sendbp(struct ship *from, struct ship *to, int sections, int isdefense)
260{
int n;
struct BP *bp;

bp = isdefense ? from->file->DBP : from->file->OBP;
for (n = 0; n < NBP3 && bp[n].turnsent; n++)
;
if (n < NBP3 && sections) {
Write(isdefense ? W_DBP5 : W_OBP14, from,
	n, turn, to->file->index, sections);
if (isdefense)
	makemsg(from, "repelling boarders");
else
	makesignal(from, "boarding the $$", to);
}
275}

277int
278is_toughmelee(struct ship *ship, struct ship *to, int isdefense, int count)
279{
struct BP *bp;
int obp = 0;
int n, OBP = 0, DBP = 0, dbp = 0;
int qual;

qual = ship->specs->qual;
bp = isdefense ? ship->file->DBP : ship->file->OBP;
for (n = 0; n < NBP3; n++, bp++) {
if (bp->turnsent && (to == bp->toship || isdefense)) {
	obp += bp->mensent / 100
		? ship->specs->crew1 * qual : 0;
	obp += (bp->mensent % 100)/10
		? ship->specs->crew2 * qual : 0;
	obp += bp->mensent % 10
		? ship->specs->crew3 * qual : 0;
}
}
if (count || isdefense)
return obp;
OBP = is_toughmelee(to, ship, 0, count + 1);
dbp = is_toughmelee(ship, to, 1, count + 1);
DBP = is_toughmelee(to, ship, 1, count + 1);
if (OBP > obp + 10 || OBP + DBP >= obp + dbp + 10)
return 1;
else
return 0;
306}

308void
309reload(void)
310{
struct ship *sp;

foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
sp->file->loadwith = 0;
}
316}

318void
319checksails(void)
320{
struct ship *sp;
int rig, full; 
struct ship *close;

foreachship(sp)for ((sp) = cc->ship; (sp) < ls; (sp)++) {
if (sp->file->captain[0] != 0)
	continue;
rig = sp->specs->rig1;
if (windspeed == 6 || (windspeed == 5 && sp->specs->class > 4))
	rig = 0;
if (rig && sp->specs->crew3) {
	close = closestenemy(sp, 0, 0);
	if (close != 0) {
		if (range(sp, close) > 9)
			full = 1;
		else
			full = 0;
	} else 
		full = 0;
} else
	full = 0;
if ((sp->file->FS != 0) != full)
	Write(W_FS31, sp, full, 0, 0, 0);
}
345}