Bug Summary

File:src/games/monop/houses.c
Warning:line 210, column 2
Value stored to 'good' is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name houses.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/games/monop/obj -resource-dir /usr/local/lib/clang/13.0.0 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/games/monop/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/games/monop/houses.c
1/* $OpenBSD: houses.c,v 1.10 2016/01/08 18:20:33 mestre Exp $ */
2/* $NetBSD: houses.c,v 1.3 1995/03/23 08:34:40 cgd Exp $ */
3
4/*
5 * Copyright (c) 1980, 1993
6 * The Regents of the University of California. All rights reserved.
7 *
8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions
10 * are met:
11 * 1. Redistributions of source code must retain the above copyright
12 * notice, this list of conditions and the following disclaimer.
13 * 2. Redistributions in binary form must reproduce the above copyright
14 * notice, this list of conditions and the following disclaimer in the
15 * documentation and/or other materials provided with the distribution.
16 * 3. Neither the name of the University nor the names of its contributors
17 * may be used to endorse or promote products derived from this software
18 * without specific prior written permission.
19 *
20 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
21 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
22 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
23 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
24 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
25 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
26 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
27 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
28 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
29 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
30 * SUCH DAMAGE.
31 */
32
33#include <stdio.h>
34#include <stdlib.h>
35
36#include "monop.ext"
37
38static char *names[N_MON8+2],
39 cur_prop[80];
40
41static MON *monops[N_MON8];
42
43static void buy_h(MON *);
44static void sell_h(MON *);
45static void list_cur(MON *);
46static int avail_houses();
47static int avail_hotels();
48static boolint8_t can_only_buy_hotel(MON *);
49
50/*
51 * These routines deal with buying and selling houses
52 */
53void
54buy_houses(void)
55{
56 int num_mon;
57 MON *mp;
58 OWN *op;
59 boolint8_t good, got_morg;
60 int i,p;
61
62over:
63 num_mon = 0;
64 good = TRUE(1);
65 got_morg = FALSE(0);
66 for (op = cur_p->own_list; op && op->sqr->type != PRPTY0; op = op->next)
67 continue;
68 while (op)
69 if (op->sqr->desc->monop) {
70 mp = op->sqr->desc->mon_desc;
71 names[num_mon] = (monops[num_mon]=mp)->name;
72 num_mon++;
73 got_morg = good = FALSE(0);
74 for (i = 0; i < mp->num_in; i++) {
75 if (op->sqr->desc->morg)
76 got_morg = TRUE(1);
77 if (op->sqr->desc->houses != 5)
78 good = TRUE(1);
79 op = op->next;
80 }
81 if (!good || got_morg)
82 --num_mon;
83 }
84 else
85 op = op->next;
86 if (num_mon == 0) {
87 if (got_morg)
88 printf("You can't build on mortgaged monopolies.\n");
89 else if (!good)
90 printf("You can't build any more.\n");
91 else
92 printf("But you don't have any monopolies!!\n");
93 return;
94 }
95 if (num_mon == 1)
96 buy_h(monops[0]);
97 else {
98 names[num_mon++] = "done";
99 names[num_mon--] = 0;
100 if ((p=getinp("Which property do you wish to buy houses for? ", names)) == num_mon)
101 return;
102 buy_h(monops[p]);
103 goto over;
104 }
105}
106
107static void
108buy_h(MON *mnp)
109{
110 int i;
111 MON *mp;
112 int price;
113 shrtchar input[3],temp[3];
114 int tot, tot2;
115 PROP *pp;
116 int nhous, nhot;
117 boolint8_t chot;
118
119 mp = mnp;
120 price = mp->h_cost * 50;
121 nhous = avail_houses();
122 nhot = avail_hotels();
123 chot = can_only_buy_hotel(mnp);
124 if (nhous == 0 && !chot) {
125 printf("Building shortage: no houses available.");
126 return;
127 }
128 if (nhot == 0 && chot) {
129 printf("Building shortage: no hotels available.");
130 return;
131 }
132blew_it:
133 list_cur(mp);
134 printf("Houses will cost $%d\n", price);
135 printf("How many houses do you wish to buy for\n");
136 for (i = 0; i < mp->num_in; i++) {
137 pp = mp->sq[i]->desc;
138over:
139 if (pp->houses == 5) {
140 printf("%s (H):\n", mp->sq[i]->name);
141 input[i] = 0;
142 temp[i] = 5;
143 continue;
144 }
145 (void)snprintf(cur_prop, sizeof(cur_prop), "%s (%d): ",
146 mp->sq[i]->name, pp->houses);
147 input[i] = get_int(cur_prop);
148 temp[i] = input[i] + pp->houses;
149 if (temp[i] > 5 || temp[i] < 0) {
150 printf("That's too many. The most you can buy is %d\n",
151 5 - pp->houses);
152 goto over;
153 }
154 }
155 if (mp->num_in == 3 && (abs(temp[0] - temp[1]) > 1 ||
156 abs(temp[0] - temp[2]) > 1 || abs(temp[1] - temp[2]) > 1)) {
157err: printf("That makes the spread too wide. Try again\n");
158 goto blew_it;
159 }
160 else if (mp->num_in == 2 && abs(temp[0] - temp[1]) > 1)
161 goto err;
162 for (tot = tot2 = i = 0; i < mp->num_in; i++) {
163 if (temp[i] == 5 && input[i])
164 tot2++;
165 else
166 tot += input[i];
167 }
168 if (tot > nhous) {
169 printf(
170"You have asked for %d house%s but only %d are available. Try again\n",
171 tot, tot == 1 ? "":"s", nhous);
172 goto blew_it;
173 } else if (tot2 > nhot) {
174 printf(
175"You have asked for %d hotel%s but only %d are available. Try again\n",
176 tot2, tot2 == 1 ? "":"s", nhot);
177 goto blew_it;
178 }
179 if (!chot && tot2) {
180 printf(
181"You must have 4 houses on all your property before building hotels\n");
182 goto blew_it;
183 }
184 if (tot || tot2) {
185 printf("You asked for %d %s%s for $%d\n", tot ? tot : tot2,
186 tot ? "house" : "hotel", (tot == 1 || tot2 == 1) ? "" : "s",
187 (tot ? tot : tot2) * price);
188 if (getyn("Is that ok? ") == 0) {
189 cur_p->money -= (tot ? tot : tot2) * price;
190 for (tot = i = 0; i < mp->num_in; i++)
191 mp->sq[i]->desc->houses = temp[i];
192 }
193 }
194}
195
196/*
197 * This routine sells houses.
198 */
199void
200sell_houses(void)
201{
202 int num_mon;
203 MON *mp;
204 OWN *op;
205 boolint8_t good;
206 int p;
207
208over:
209 num_mon = 0;
210 good = TRUE(1);
Value stored to 'good' is never read
211 for (op = cur_p->own_list; op; op = op->next)
212 if (op->sqr->type == PRPTY0 && op->sqr->desc->monop) {
213 mp = op->sqr->desc->mon_desc;
214 names[num_mon] = (monops[num_mon]=mp)->name;
215 num_mon++;
216 good = 0;
217 do
218 if (!good && op->sqr->desc->houses != 0)
219 good++;
220 while (op->next && op->sqr->desc->mon_desc == mp
221 && (op=op->next));
222 if (!good)
223 --num_mon;
224 }
225 if (num_mon == 0) {
226 printf("You don't have any houses to sell!!\n");
227 return;
228 }
229 if (num_mon == 1)
230 sell_h(monops[0]);
231 else {
232 names[num_mon++] = "done";
233 names[num_mon--] = 0;
234 if ((p=getinp("Which property do you wish to sell houses from? ", names)) == num_mon)
235 return;
236 sell_h(monops[p]);
237 notify();
238 goto over;
239 }
240}
241
242static void
243sell_h(MON *mnp)
244{
245 int i;
246 MON *mp;
247 int price;
248 shrtchar input[3],temp[3];
249 int tot;
250 PROP *pp;
251
252 mp = mnp;
253 price = mp->h_cost * 25;
254blew_it:
255 printf("Houses will get you $%d apiece\n", price);
256 list_cur(mp);
257 printf("How many houses do you wish to sell from\n");
258 for (i = 0; i < mp->num_in; i++) {
259 pp = mp->sq[i]->desc;
260over:
261 if (pp->houses == 0) {
262 printf("%s (0):\n", mp->sq[i]->name);
263 input[i] = temp[i] = 0;
264 continue;
265 }
266 if (pp->houses < 5)
267 (void)snprintf(cur_prop, sizeof(cur_prop), "%s (%d): ",
268 mp->sq[i]->name,pp->houses);
269 else
270 (void)snprintf(cur_prop, sizeof(cur_prop), "%s (H): ",
271 mp->sq[i]->name);
272 input[i] = get_int(cur_prop);
273 temp[i] = pp->houses - input[i];
274 if (temp[i] < 0) {
275 printf("That's too many. The most you can sell is %d\n", pp->houses);
276 goto over;
277 }
278 }
279 if (mp->num_in == 3 && (abs(temp[0] - temp[1]) > 1 ||
280 abs(temp[0] - temp[2]) > 1 || abs(temp[1] - temp[2]) > 1)) {
281err: printf("That makes the spread too wide. Try again\n");
282 goto blew_it;
283 }
284 else if (mp->num_in == 2 && abs(temp[0] - temp[1]) > 1)
285 goto err;
286 for (tot = i = 0; i < mp->num_in; i++)
287 tot += input[i];
288 if (tot) {
289 printf("You asked to sell %d house%s for $%d\n", tot,
290 tot == 1 ? "" : "s", tot * price);
291 if (getyn("Is that ok? ") == 0) {
292 cur_p->money += tot * price;
293 for (tot = i = 0; i < mp->num_in; i++)
294 mp->sq[i]->desc->houses = temp[i];
295 }
296 }
297}
298
299static void
300list_cur(MON *mp)
301{
302 int i;
303 SQUARE *sqp;
304
305 for (i = 0; i < mp->num_in; i++) {
306 sqp = mp->sq[i];
307 if (sqp->desc->houses == 5)
308 printf("%s (H) ", sqp->name);
309 else
310 printf("%s (%d) ", sqp->name, sqp->desc->houses);
311 }
312 putchar('\n')(!__isthreaded ? __sputc('\n', (&__sF[1])) : (putc)('\n',
(&__sF[1])))
;
313}
314
315static int
316avail_houses(void)
317{
318 int i, c;
319 SQUARE *sqp;
320
321 c = 0;
322 for (i = 0; i < N_SQRS40; i++) {
323 sqp = &board[i];
324 if (sqp->type == PRPTY0 && sqp->owner >= 0 && sqp->desc->monop) {
325 if (sqp->desc->houses < 5 && sqp->desc->houses > 0)
326 c += sqp->desc->houses;
327 }
328 }
329 return(N_HOUSE32 - c);
330}
331
332static int
333avail_hotels(void)
334{
335 int i, c;
336 SQUARE *sqp;
337
338 c = 0;
339 for (i = 0; i < N_SQRS40; i++) {
340 sqp = &board[i];
341 if (sqp->type == PRPTY0 && sqp->owner >= 0 && sqp->desc->monop) {
342 if (sqp->desc->houses == 5)
343 c++;
344 }
345 }
346 return(N_HOTEL12 - c);
347}
348
349static boolint8_t
350can_only_buy_hotel(MON *mp)
351{
352 int i;
353
354 for (i = 0; i < mp->num_in; i++) {
355 if (mp->sq[i]->desc->houses < 4)
356 return(FALSE(0));
357 }
358 return(TRUE(1));
359}