/usr/src/usr.bin/banner/banner.c

Bug Summary

File:	src/usr.bin/banner/banner.c
Warning:	line 135, column 18 The left operand of '==' is a garbage value

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name banner.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.bin/banner/obj -resource-dir /usr/local/lib/clang/13.0.0 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.bin/banner/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/usr.bin/banner/banner.c

1/*	$OpenBSD: banner.c,v 1.13 2017/05/27 07:55:44 tedu Exp $	*/
2/*	$NetBSD: banner.c,v 1.2 1995/04/09 06:00:15 cgd Exp $	*/

4/*
*	Changes for banner(1)
*
*      @(#)Copyright (c) 1995, Simon J. Gerraty.
*      
*      This is free software.  It comes with NO WARRANTY.
*      Permission to use, modify and distribute this source code 
*      is granted subject to the following conditions.
*      1/ that the above copyright notice and this notice 
*      are preserved in all copies and that due credit be given 
*      to the author.  
*      2/ that any changes to this code are clearly commented 
*      as such so that the author does not get blamed for bugs 
*      other than his own.
*      
*      Please send copies of changes and bug-fixes to:
*      sjg@zen.void.oz.au
*/

23/*
* Copyright (c) 1983, 1993
*	The Regents of the University of California.  All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
*    notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
*    notice, this list of conditions and the following disclaimer in the
*    documentation and/or other materials provided with the distribution.
* 3. Neither the name of the University nor the names of its contributors
*    may be used to endorse or promote products derived from this software
*    without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/

52#include <stdio.h>
53#include <unistd.h>
54#include <stdlib.h>
55#include <string.h>
56#include <err.h>

58#include "banner.h"

60static long PW = LINELEN132;

62/* the char gen code below is lifted from lpd */

64static char *
65scnline(int key, char *p, int c)
66{
int scnwidth;

/*
* <sjg> lpd makes chars out of the letter in question.
* the results are somewhat mixed.  Sticking to '#' as
* banner(1) does is more consistent.
*/
c = '#';

for (scnwidth = WIDTH8; --scnwidth;) {
key <<= 1;
*p++ = key & 0200 ? c : BACKGND' ';
}
return (p);
81}

83#define TRC(q)(((q)-' ')&0177)	(((q)-' ')&0177)


86static int
87dropit(int c)
88{
switch(c) {

case TRC('_')((('_')-' ')&0177):
case TRC(';')(((';')-' ')&0177):
case TRC(',')(((',')-' ')&0177):
case TRC('g')((('g')-' ')&0177):
case TRC('j')((('j')-' ')&0177):
case TRC('p')((('p')-' ')&0177):
case TRC('q')((('q')-' ')&0177):
case TRC('y')((('y')-' ')&0177):
return (DROP0);

default:
return (0);
}
104}

106static void
107scan_out(int scfd, char *scsp, int dlm)
108{
char *strp;
int nchrs, j;
char outbuf[LINELEN132+1], *sp, c, cc;
int d, scnhgt;
extern char scnkey[][HEIGHT8];	/* in lpdchar.c */

for (scnhgt = 0; scnhgt++ < HEIGHT8+DROP0; ) {
5
←
Loop condition is true.  Entering loop body→
strp = &outbuf[0];
sp = scsp;
for (nchrs = 0; *sp != dlm && *sp != '\0'; ) {
6
←
Assuming the condition is false→
	cc = *sp++;
	if ((unsigned char)cc < ' ' ||
	    (unsigned char)cc > 0x7f)
		cc = INVALID'_';

	c = TRC(cc)(((cc)-' ')&0177);
	d = dropit(c);
	if ((!d && scnhgt > HEIGHT8) || (scnhgt <= DROP0 && d))
		for (j = WIDTH8; --j;)
			*strp++ = BACKGND' ';
	else
		strp = scnline(scnkey[(int)c][scnhgt-1-d], strp, cc);
	if (nchrs++ >= PW/(WIDTH8+1)-1)
		break;
	*strp++ = BACKGND' ';
}
while (*--strp == BACKGND' ' && strp >= outbuf)
7
←
The left operand of '==' is a garbage value
	;
strp++;
*strp++ = '\n';	
(void) write(scfd, outbuf, strp-outbuf);
}
141}

143/*
* for each word, print up to 10 chars in big letters.
*/
146int
147main(int argc, char *argv[])
148{
char word[10+1];			/* strings limited to 10 chars */

if (pledge("stdio", NULL((void *)0)) == -1)
1
Assuming the condition is false→
2
←
Taking false branch→
err(1, "pledge");

while (*++argv) {
3
←
Loop condition is true.  Entering loop body→
(void)strlcpy(word, *argv, sizeof (word));
scan_out(1, word, '\0');
4
←
Calling 'scan_out'→
}
exit(0);
159}